Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive gRPC resolver logging #10183

Closed
mkeeler opened this issue May 5, 2021 · 1 comment · Fixed by #10395
Closed

Remove excessive gRPC resolver logging #10183

mkeeler opened this issue May 5, 2021 · 1 comment · Fixed by #10395
Labels
theme/api Relating to the HTTP API interface theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Milestone

Comments

@mkeeler
Copy link
Member

mkeeler commented May 5, 2021

Overview of the Issue

Using the master branch, I spun up a dev agent and noticed a bunch of weird looking logs:

  2021-05-05T10:17:42.971-0400 [INFO]  agent: ccResolverWrapper: sending update to cc: {[{127.0.0.1:8300 0 hashimac.keeler.lan <nil>}] <nil>}
    2021-05-05T10:17:42.971-0400 [INFO]  agent: ccResolverWrapper: sending update to cc: {[{127.0.0.1:8300 0 hashimac.keeler.lan <nil>}] <nil>}
    2021-05-05T10:17:42.971-0400 [INFO]  agent: addrConn: tryUpdateAddrs curAddr: { 0  <nil>}, addrs: [{127.0.0.1:8300 0 hashimac.keeler.lan <nil>}]

These are periodically emitted and at the info level. From what I have been able to gather it looks like internal gRPC logging from here and a couple other locations.

Why the gRPC library thinks these should be info levels I don't know. But for our purposes these are really more like debug/trace level logging.

We do implement our own gRPC logger including filtering of gRPC log levels.

I am thinking we could do something with our logger implementation to downgrade the level set by gRPC at least in the case of the info logs.

Reproduction Steps

Run a dev agent from master.

@mkeeler mkeeler added this to the 1.10.0 milestone May 5, 2021
@jsosulska jsosulska added theme/api Relating to the HTTP API interface theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature labels May 6, 2021
@mkeeler
Copy link
Member Author

mkeeler commented Jun 14, 2021

Looks like there were upstream issues about this: grpc/grpc-go#3918

From my reading of that thread the grpc info level logs really are what we would classify as debug/trace logs.

I think we should probably update our grpc logger to send info level logs out as trace logs for hclog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/api Relating to the HTTP API interface theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants