Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix back compat issues with UDS config #11318

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fix back compat issues with UDS config #11318

merged 1 commit into from
Oct 28, 2021

Conversation

markan
Copy link
Contributor

@markan markan commented Oct 14, 2021

SocketPath needs to be omitted when empty to avoid confusing older versions of Consul

Signed-off-by: Mark Anderson manderson@hashicorp.com

@github-actions github-actions bot added the theme/api Relating to the HTTP API interface label Oct 14, 2021
@vercel vercel bot temporarily deployed to Preview – consul October 14, 2021 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 14, 2021 18:57 Inactive
@markan
Fix back compat issues with UDS config
fa86e42 
SocketPath needs to be omitted when empty to avoid confusing older versions of Consul

Signed-off-by: Mark Anderson <manderson@hashicorp.com>
@vercel vercel bot temporarily deployed to Preview – consul October 14, 2021 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 14, 2021 20:18 Inactive
dnephin
dnephin approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rboyer
rboyer approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we cherry pick this to a stable release branch (1.10.x) and use that to cut a new api release since we can't use main yet?

@david-yu
Copy link
Contributor

@markan Could we back port to 1.10, 1.9,and 1.8? We have seen this issue surface on environments in 1.8.

@rboyer
Copy link
Member

rboyer commented Oct 15, 2021

@david-yu it's an API library-only thing, so we just have to tag a new version of consul/api. There shouldn't be a need to backport specifically. I was only mentioning above that we might have to backport it so we can ship an api tag from somewhere before 1.11 goes out.

@markan markan merged commit 977be77 into main Oct 28, 2021
@markan markan deleted the markan/backcompat branch October 28, 2021 20:31
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/488812.

@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit 977be77 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Oct 28, 2021
@markan @hc-github-team-consul-core
Fix back compat issues with UDS config (#11318)
78a44ce 
SocketPath needs to be omitted when empty to avoid confusing older versions of Consul

Signed-off-by: Mark Anderson <manderson@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer approved these changes

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
theme/api Relating to the HTTP API interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@markan @david-yu @rboyer @hc-github-team-consul-core @dnephin