-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix back compat issues with UDS config #11318
Conversation
9f77606
to
015d379
Compare
SocketPath needs to be omitted when empty to avoid confusing older versions of Consul Signed-off-by: Mark Anderson <manderson@hashicorp.com>
015d379
to
fa86e42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should we cherry pick this to a stable release branch (1.10.x) and use that to cut a new api release since we can't use main
yet?
@markan Could we back port to 1.10, 1.9,and 1.8? We have seen this issue surface on environments in 1.8. |
@david-yu it's an API library-only thing, so we just have to tag a new version of |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/488812. |
🍒✅ Cherry pick of commit 977be77 onto |
SocketPath needs to be omitted when empty to avoid confusing older versions of Consul Signed-off-by: Mark Anderson <manderson@hashicorp.com>
SocketPath needs to be omitted when empty to avoid confusing older versions of Consul
Signed-off-by: Mark Anderson manderson@hashicorp.com