ui: Adding partitions + icons to upstreams/upstream instances #11556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
force-pushed
the
ui/feature/more-partition-icons
branch
from
10b9d42
to
dcc8a08
Compare
kaxcode
reviewed
Nov 17, 2021
| @@ -11,6 +11,20 @@ | |||
| </p> | |||
| </div> | |||
| <div class="detail"> | |||
| {{#if (env 'CONSUL_PARTITIONS_ENABLED')}} | |||
There was a problem hiding this comment.
can can use partitions be used here?
There was a problem hiding this comment.
Yes definitely! Gimme 2 tics
There was a problem hiding this comment.
K thats done, both here and below.
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/505091. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a partition badge/label/visual to upstreams and upstream instances.
I also took the opportunity to fill out some documentation for both types of listing that I changed here