-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Adding partitions + icons to upstreams/upstream instances #11556
Conversation
10b9d42
to
dcc8a08
Compare
@@ -11,6 +11,20 @@ | |||
</p> | |||
</div> | |||
<div class="detail"> | |||
{{#if (env 'CONSUL_PARTITIONS_ENABLED')}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can can use partitions
be used here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes definitely! Gimme 2 tics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K thats done, both here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/505091. |
Adds a partition badge/label/visual to upstreams and upstream instances.
I also took the opportunity to fill out some documentation for both types of listing that I changed here