-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent service registry slowdown #1265
Comments
@slackpad did you do anything with this since hashiconf ? |
@spheromak I think #1296 is a partial fix at least. Do those services have checks associated, or are there just 10K services without checks? |
Hi @spheromak sorry for the delay on this, and thanks @armon. Your change in #1296 looks good but iirc there were no health checks for these services. Looking at the code I'm surprised there's not an n^2 loop over services so I'm not sure this alone will fix it. |
No agent checks. We were planning on doing http callbacks for service On Mon, Oct 12, 2015 at 9:15 PM James Phillips notifications@github.com
|
This may have been causing the slowdown. I am traveling this week but will
|
agent: remove an N^2 check. See #1265
#1296 has been working well - closing this out. |
Per the conversation on the mailing list here: https://groups.google.com/forum/#!searchin/consul-tool/thousands$20of$20services/consul-tool/vPAhS1EhABM/_SPAIXuMFDQJ
There is a slowdown due to how the gent loops over all services and the catalog returned from the server that completes in O(N^2). After talking with @slackpad at HashiConf we think that we can improve on this fairly simply with an index on the server result.
The text was updated successfully, but these errors were encountered: