-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static asset compilation for Consul UI #1543
Conversation
508c6d8
to
533aa75
Compare
Code LGTM but the build failure looks related to this change:
|
Huh... I had checked out go-bindata-assetfs a while back. Upon updating I see this problem locally. Seems related to elazarl/go-bindata-assetfs#23 |
I fixed this, just needed to re-generate the assets, but now I'm getting some really scary test failures from inside the state store and all over the place. I'll try pushing this through travis a few more times and see what we get. |
35bbafd
to
87c1283
Compare
Test failures are now unrelated to this so going to merge this in. |
Static asset compilation for Consul UI
Adds the static web assets into the Consul binary with an explicit flag required to enable.
Thanks to @rgl for prior art in #1274.