Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still recommended to set GOMAXPROCS > 1? #1679

Closed
Amit-PivotalLabs opened this issue Feb 3, 2016 · 5 comments
Closed

Still recommended to set GOMAXPROCS > 1? #1679

Amit-PivotalLabs opened this issue Feb 3, 2016 · 5 comments

Comments

@Amit-PivotalLabs
Copy link

There is this old thread on googlegroups asking about why consul warns to set GOMAXPROCS > 1 on startup. Then there's a commit which removes these warnings due to changes in Golang 1.5. But what about machines with 1 core? In this case is it necessary to manually set GOMAXPROCS to something else? And if so, does it matter what, is 2 ok?

/cc @fraenkel
@highlyunavailable
Copy link
Contributor

The only reason it needed to be set is in case cgo blocked a thread when talking to the data store (LMDB). Since Consul has moved to a pure Go data store (memory + snapshots to boltdb, if I recall correctly) GOMAXPROCS is fine to leave at 1 on 1-core machines. In other words, the only reason was cgo, and since cgo is no longer used, it is okay to leave gomaxprocs at the default, even if the default is 1 since Consul is pure Go now.

@slackpad
Copy link
Contributor

slackpad commented Feb 3, 2016

That's correct - it should be fine to leave as-is for single core machines now that all the cgo stuff has been eliminated. This came in originally in #10.

@slackpad slackpad closed this as completed Feb 3, 2016
@Amit-PivotalLabs
Copy link
Author

Perfect, thanks @highlyunavailable and @slackpad!

@fraenkel
Copy link

fraenkel commented Feb 3, 2016

@Amit-PivotalLabs This is true for v0.6.0 or greater.

@Amit-PivotalLabs
Copy link
Author

Thanks, noted.

On Wed, Feb 3, 2016 at 6:24 AM, Michael Fraenkel notifications@github.com
wrote:

@Amit-PivotalLabs https://github.com/Amit-PivotalLabs This is true for
v0.6.0 or greater.

—
Reply to this email directly or view it on GitHub
#1679 (comment).

seiflek pushed a commit to seiflek/gentoo that referenced this issue Jul 15, 2019
@austin987 @zmedico
app-admin/consul: remove GOMAXPROCS from init script
5c2a979 
This hasn't been needed since consul-0.6.0:
hashicorp/consul#1679

Signed-off-by: Austin English <austin.m.english@sony.com>
Copyright: Sony Interactive Entertainment Inc.
Signed-off-by: Zac Medico <zmedico@gentoo.org>
zmedico added a commit to zmedico/gentoo that referenced this issue Jul 15, 2019
@zmedico
app-admin/consul: remove GOMAXPROCS from conf.d file and systemd unit
702b2ef 
This hasn't been needed since consul-0.6.0.

See: hashicorp/consul#1679
Copyright: Sony Interactive Entertainment Inc.
Signed-off-by: Zac Medico <zmedico@gentoo.org>
eifelmicha added a commit to Rheinwerk/ansible-role-consul that referenced this issue Oct 27, 2021
@eifelmicha
[#169058673] Ablöse des Shellskripts zum Starten von Consul auf Syste…
ea04d1e 
…mD Systemen

- GOMAXPROCS ist nicht mehr notwendig, siehe hashicorp/consul#1679
- die restlichen Parameter werden zugunsten des EnvironmentFile aufgegeben
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@slackpad @fraenkel @Amit-PivotalLabs @highlyunavailable