-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACLs Enabled field to consul agent startup status message #17086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on!
I have one important suggestion for improvement in the comments.
Addressed in most recent commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a PM/UX perspective. Someone from eng needs to give an eng review though (which shouldn't take long). I recommend selecting someone from the team or posting on our Slack channel asking for a review.
Looks like adding the I forget that it auto-selects a specific individual from the group. Handy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
When starting the consul agent, we output a status message which shows various parts of the configuration including
Gossip Encryption
andAuto-Encrypt-TLS
configurations.This adds another field to the status showing whether or not ACLs are enabled.
Testing & Reproduction steps
PR Checklist