Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACLs Enabled field to consul agent startup status message #17086

Merged
merged 4 commits into from
May 16, 2023
Merged

Conversation

johnlanda
Copy link
Contributor

Description

When starting the consul agent, we output a status message which shows various parts of the configuration including Gossip Encryption and Auto-Encrypt-TLS configurations.

This adds another field to the status showing whether or not ACLs are enabled.

Testing & Reproduction steps

make dev
./bin/consul agent -dev

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the theme/cli Flags and documentation for the CLI interface label Apr 21, 2023
Copy link
Contributor

@jkirschner-hashicorp jkirschner-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

I have one important suggestion for improvement in the comments.

command/agent/agent.go Outdated Show resolved Hide resolved
@johnlanda johnlanda marked this pull request as draft April 21, 2023 17:15
@johnlanda johnlanda marked this pull request as ready for review May 16, 2023 15:00
@johnlanda johnlanda dismissed jkirschner-hashicorp’s stale review May 16, 2023 15:00

Addressed in most recent commit

Copy link
Contributor

@jkirschner-hashicorp jkirschner-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a PM/UX perspective. Someone from eng needs to give an eng review though (which shouldn't take long). I recommend selecting someone from the team or posting on our Slack channel asking for a review.

@jkirschner-hashicorp jkirschner-hashicorp requested review from a team and skpratt and removed request for a team May 16, 2023 17:41
@jkirschner-hashicorp
Copy link
Contributor

jkirschner-hashicorp commented May 16, 2023

Looks like adding the hashicorp/consul-zts reviewer auto-assigned @skpratt :)

I forget that it auto-selects a specific individual from the group. Handy!

command/agent/agent.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cthain cthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnlanda johnlanda merged commit 8f6b9fe into main May 16, 2023
@johnlanda johnlanda deleted the NET-2319 branch May 16, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport theme/cli Flags and documentation for the CLI interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants