fix(v2dns): add node ttl to workloads, comment cleanup, and changelog #20643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanStough
force-pushed
the
dans/NET-7485/docs
branch
from
8348fa0 to
17de0e4
Compare
zalimeni
approved these changes
Feb 14, 2024
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR started out as comment cleanup but ended up including some functional changes, including eliminating some unused fields and adding the Node TTLs to Workloads (which was discussed previously with Keeler).
The changelog for V2 DNS is also included here.
Testing & Reproduction steps
PR Checklist
external facing docs updated