Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple checks attached to a service #230

Closed
keyneston opened this issue Jun 25, 2014 · 13 comments · Fixed by #591
Closed

Allow multiple checks attached to a service #230

keyneston opened this issue Jun 25, 2014 · 13 comments · Fixed by #591
Labels
type/enhancement Proposed improvement or new feature

Comments

@keyneston
Copy link

It would be useful if a service can have multiple checks associated with it. For example you might want a check for seeing if the service is alive and a check to make sure that the service is running the correct software version.

By allowing multiple checks its then possible to build generic checks for checking version while having a check specific to the service for checking if the service is running.

@abursavich
Copy link
Contributor

I ran into a similar situation where I wanted multiple checks for a single service and was surprised to realize that it wasn't allowed.

@armon
Copy link
Member

armon commented Jun 27, 2014

So internally we allow multiple checks per service, it is just a limitation of our config file format. We can probably add a "checks" key such that a list of checks can be provided instead of a single "check" block.

@armon
Copy link
Member

armon commented Jun 27, 2014

As a work around, using the API will allow multiple checks to be registered

@abursavich
Copy link
Contributor

The only way that I could see to register multiple was to go through the catalog endpoints instead of the agent endpoints. Will the anti-entropy in the agent remove any services/checks/etc that weren't registered through it?

@armon
Copy link
Member

armon commented Jun 29, 2014

@abursavich Hmm that is a good point. I think you are right, the agent will deregister them when anti-entropy happens.

@geku
Copy link

geku commented Jun 30, 2014

From my point of view it's important to be able to register/deregister service health checks independent of the service itself. This allows to add health checks at a later time without re-regestring the service itself. Currently it's only possible to register the one service health check together with the service.

@abursavich
Copy link
Contributor

This is really a different issue, but if there will be changes to service registration I'd just like to note that it's important to be able to mutate a service definition without having to deregister then reregister it. Consider acquiring a lock and then needing to add a tag (e.g. "master") without losing the lock by first deregistering the service and its associated health checks.

@armon
Copy link
Member

armon commented Jul 1, 2014

I agree with all of the above 👍

@armon armon added the type/enhancement Proposed improvement or new feature label Oct 14, 2014
@bcwilsondotcom
Copy link

Any updates on this one? Allowing multiple checks on a service is desperately needed.

@armon
Copy link
Member

armon commented Nov 18, 2014

Not yet, but it is top of mind!

@janitha
Copy link

janitha commented Dec 11, 2014

+1 Would be really useful to be able to attach multiple health checks per service

@amiorin
Copy link

amiorin commented Dec 17, 2014

👍

1 similar comment
@rrreeeyyy
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants