Adds new consul operator endpoint, CLI, and ACL and some basic Raft commands. #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Put this up as a checkpoint but it's not quite ready for review. Code is complete but I need to finish off the documentation. |
| // doing if you are calling this. If you remove a peer that's known to | ||
| // Serf, for example, it will come back when the leader does a reconcile | ||
| // pass. | ||
| future := op.srv.raft.RemovePeer(args.Address) |
There was a problem hiding this comment.
I would log this at a pretty high level, maybe like WARN. Including the error or success of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
/v1/operatorAPI and correspondingconsul operatorset of commands to help Consul operators perform cluster level actions. We've added a some Raft actions to start:consul operator raft -list-peersshows detailed status about the Raft configuration.consul operator raft -remove-peerallows a stale peer to be kicked out on the fly without having to shut down the cluster and edit the peers.json file. Fixes Add command for viewing/editing raft/peers.json? #1417 and helps with Make it easier to debug split brains and Raft-related Consul problems #1374.This will be a good framework for other cluster-wide recovery and maintenance operations, and we've also added a corresponding
operatorACL with separate read and write states so authority to diagnose and fix can be delegated.