Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon.png no longer found #2945

Closed
skippy opened this issue Apr 23, 2017 · 0 comments
Closed

favicon.png no longer found #2945

skippy opened this issue Apr 23, 2017 · 0 comments

Comments

@skippy
Copy link

skippy commented Apr 23, 2017

hi folks,

I recently updated to v0.8.1, and I'm now seeing this in my haproxy logs (I have an haproxy gateway in front of the consul ui)

172.17.0.9:34244 [23/Apr/2017:16:37:01.581] internal-verified internal-consul-backend/local-consul 73/0/0/0/73 500 214 - - ---- 5/2/0/1/0 0/0 "GET /ui/static/favicon.png HTTP/1.1"

(notice the 500 error code)

looking at the current code base (as of today), i see favicon.png referenced here: https://github.com/hashicorp/consul/blob/master/ui/index.html

but the favicon.png was removed in this PR: 6ab19b9

can we get this cleaned up please? (perhaps just add a symlink to ui/static/favicon-32x32.png?)

Thanks!

consul version for both Client and Server

Client:

Consul v0.8.1
Protocol 2 spoken by default, understands 2 to 3 (agent will automatically use protocol >2 when speaking to compatible agents)

Server:

Consul v0.8.1
Protocol 2 spoken by default, understands 2 to 3 (agent will automatically use protocol >2 when speaking to compatible agents)
brianshumate added a commit that referenced this issue Apr 25, 2017
magiconair pushed a commit that referenced this issue Apr 25, 2017
johncowen pushed a commit that referenced this issue May 4, 2018
ui: Add and update favicons

* Add most popular device/size favicon combinations
* Update existing favicons
* Change permissions to 0644 on static assets

Fixes #2945
johncowen pushed a commit that referenced this issue May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant