Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the web UI as a separately released package. #3292

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

slackpad
Copy link
Contributor

Since we have this built-in via the -ui configuration, the only reason
to use -ui-dir is if you are tweaking the web UI, so there's no need
to release the web UI as a .zip archive separately.

Since we have this built-in via the `-ui` configuration, the only reason
to use `-ui-dir` is if you are tweaking the web UI, so there's no need
to release the web UI as a .zip archive separately.
@magiconair
Copy link
Contributor

LGTM

@magiconair magiconair merged commit d141ed9 into master Jul 18, 2017
@magiconair magiconair deleted the no-more-webui branch July 18, 2017 07:13
@scareything
Copy link

Our team has found the separate UI package to be very useful. We run consul behind a proxy and need to set consulHost so the UI's REST calls are correctly redirected to consul.

Unless consul provides a configuration option to effectively set consulHost, this change is going to prevent some people from upgrading. Please add a consulHost configuration option to consul, or continue releasing the UI separately.

@magiconair
Copy link
Contributor

I think the right way to address this is to make consulHost configurable. I'll open another issue.

@slackpad
Copy link
Contributor Author

@scareything sorry we broke that, I had forgotten about that variable when I made this change. As a workaround for this release you could pull the source tree from https://github.com/hashicorp/consul/releases for 0.9.0 (https://github.com/hashicorp/consul/archive/v0.9.0.zip) and use the ui subdirectory in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants