Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate a better address error #3312

Closed
slackpad opened this issue Jul 21, 2017 · 0 comments · Fixed by hashicorp/memberlist#130
Closed

Propagate a better address error #3312

slackpad opened this issue Jul 21, 2017 · 0 comments · Fixed by hashicorp/memberlist#130
Labels
theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature

Comments

@slackpad
Copy link
Contributor

slackpad commented Jul 21, 2017

The unit test cleanup in memberlist ended up burying the real error message if an address isn't available. For example, with some other listener on an address/port normally you'd get an "address already in use" type error, but instead you get this:

==> Error starting agent: Failed to start Consul client: Failed to start lan serf: Failed to create memberlist: Could not set up network transport: ran out of tries to obtain an address

We need to propagate the underlying error.

@slackpad slackpad added type/enhancement Proposed improvement or new feature theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner labels Jul 21, 2017
@slackpad slackpad reopened this Aug 7, 2017
slackpad added a commit that referenced this issue Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant