Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targeting "consul" service for remote exec does not work #344

Closed
armon opened this issue Sep 16, 2014 · 1 comment
Closed

Targeting "consul" service for remote exec does not work #344

armon opened this issue Sep 16, 2014 · 1 comment
Assignees
@ryanuber
Labels
type/bug Feature does not function as expected

Comments

@armon
Copy link
Member

armon commented Sep 16, 2014

Because this service is "magical" it is not in the agent's registered list, and targeting a remote exec does not work. We need to handle being a server-mode agent to respect this service.
@armon armon added the type/bug Feature does not function as expected label Sep 16, 2014
@ryanuber ryanuber self-assigned this Oct 14, 2014
@ryanuber
Copy link
Member

@armon I've been exploring this a bit today. I noticed that consul itself is what is registering the "consul" service. I've been able to also get the service registered in the agent with a few simple lines. I think we can probably take the registration out of consul itself now and let the anti-entropy handle it. The question now is how we get any guarantee that the anti-entropy has run. Right now, l.changeMade() is just called from the AddService() method on localState, so if that runs immediately after starting the server (likely before any leader is elected), I'm not sure it will work reliably. This definitely creates problems for the tests as well.

Any ideas on how to better approach this?

@ryanuber ryanuber mentioned this issue Oct 15, 2014
Merged
duckhan pushed a commit to duckhan/consul that referenced this issue Oct 24, 2021
@alvin-huang
Pull consul dev images (hashicorp#344)
6f37b01 
* add ci config to pull s3 dev builds for tests

* pick some initial oss/ent hashes of dev builds

* use env var properly

* use the directory flag properly to untar

* use sudo for tar to access /usr/local/bin
duckhan pushed a commit to duckhan/consul that referenced this issue Oct 24, 2021
@alvin-huang
Revert "Pull consul dev images (hashicorp#344)" (hashicorp#387)
5854bff 
This reverts commit 6f37b01.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanuber ryanuber

Labels
type/bug Feature does not function as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armon @ryanuber