Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic: sync: negative WaitGroup counter #3877

Closed
vvchik opened this issue Feb 9, 2018 · 0 comments
Closed

panic: sync: negative WaitGroup counter #3877

vvchik opened this issue Feb 9, 2018 · 0 comments
Labels
type/bug Feature does not function as expected type/crash The issue description contains a golang panic and stack trace
Milestone

Comments

@vvchik
Copy link

vvchik commented Feb 9, 2018

Consull 1.0.5 falls with golang panic:
This behavior not reproducible with 1.0.3

consul[19856]: ==> Starting Consul agent...
consul[19856]: ==> Consul agent running!
consul[19856]:            Version: 'v1.0.5'
consul[19856]:            Node ID: 'xxxxxxxx-34e6-704a-xxxx-xxxxxxxxxxxx'
consul[19856]:          Node name: 'node.ip.domain.com'
consul[19856]:         Datacenter: 'sandbox' (Segment: '')
consul[19856]:             Server: false (Bootstrap: false)
consul[19856]:        Client Addr: [0.0.0.0] (HTTP: 8500, HTTPS: -1, DNS: 53)
consul[19856]:       Cluster Addr: 10.0.0.5 (LAN: 8301, WAN: 8302)
consul[19856]:            Encrypt: Gossip: true, TLS-Outgoing: true, TLS-Incoming: true
consul[19856]: ==> Log data will now stream in as it occurs:
consul[19856]:     2018/02/09 01:14:37 [INFO] serf: EventMemberJoin: node.ip.domain.com 10.0.0.5
consul[19856]:     2018/02/09 01:14:37 [INFO] agent: Started DNS server 0.0.0.0:53 (tcp)
consul[19856]:     2018/02/09 01:14:37 [INFO] agent: Started DNS server 0.0.0.0:53 (udp)
consul[19856]:     2018/02/09 01:14:37 [INFO] agent: Started HTTP server on [::]:8500 (tcp)
consul[19856]:     2018/02/09 01:14:37 [INFO] agent: started state syncer
consul[19856]:     2018/02/09 01:14:37 [INFO] agent: Retry join LAN is supported for: aliyun aws azure digitalocean gce os scaleway softlayer
consul[19856]:     2018/02/09 01:14:37 [INFO] agent: Joining LAN cluster...
consul[19856]:     2018/02/09 01:14:37 [INFO] agent: (LAN) joining: [cluster.loadbalancer.local]
consul[19856]:     2018/02/09 01:14:37 [WARN] manager: No servers available
consul[19856]:     2018/02/09 01:14:37 [ERR] agent: failed to sync remote state: No known Consul servers
consul[19856]: panic: sync: negative WaitGroup counter
consul[19856]: goroutine 52 [running]:
consul[19856]: sync.(*WaitGroup).Add(0xc4204000a0, 0xffffffffffffffff)
consul[19856]:         /goroot/src/sync/waitgroup.go:75 +0x134
consul[19856]: sync.(*WaitGroup).Done(0xc4204000a0)
consul[19856]:         /goroot/src/sync/waitgroup.go:100 +0x34
consul[19856]: github.com/hashicorp/consul/vendor/github.com/miekg/dns.(*Server).serve(0xc420400000, 0x1db8860, 0xc4204cfc80, 0x1db0da0, 0xc420150b80, 0xc420220b70, 0x2c, 0x2c, 0x0, 0x0, ...)
consul[19856]:         /gopath/src/github.com/hashicorp/consul/vendor/github.com/miekg/dns/server.go:611 +0x3ae
consul[19856]: github.com/hashicorp/consul/vendor/github.com/miekg/dns.(*Server).serveTCP.func1(0xc420150c10, 0x1dc3e00, 0xc42021a428, 0x77359400, 0xc420400000, 0xc420150c20)
consul[19856]:         /gopath/src/github.com/hashicorp/consul/vendor/github.com/miekg/dns/server.go:498 +0x141
consul[19856]: created by github.com/hashicorp/consul/vendor/github.com/miekg/dns.(*Server).serveTCP
consul[19856]:         /gopath/src/github.com/hashicorp/consul/vendor/github.com/miekg/dns/server.go:492 +0x2e3
systemd[1]: consul.service: Main process exited, code=exited, status=2/INVALIDARGUMENT

Reproduction steps

run consul-client against consul-server

consul version for both Client and Server

Client: 1.0.5
Server: 1.0.2

Operating system and Environment details

cluster is behind of ELB,
both client and cluster using ubuntu 16.04

@slackpad slackpad added type/bug Feature does not function as expected type/crash The issue description contains a golang panic and stack trace labels Feb 9, 2018
@slackpad slackpad added this to the Next milestone Feb 9, 2018
slackpad added a commit that referenced this issue Feb 9, 2018
This came in via the monkey patch in #3861.

Fixes #3877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Feature does not function as expected type/crash The issue description contains a golang panic and stack trace
Projects
None yet
Development

No branches or pull requests

2 participants