Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.9.4 breaks Solaris release build #3879

Closed
slackpad opened this issue Feb 9, 2018 · 2 comments · Fixed by #3988
Closed

Go 1.9.4 breaks Solaris release build #3879

slackpad opened this issue Feb 9, 2018 · 2 comments · Fixed by #3988
Labels
type/bug Feature does not function as expected
Milestone
1.0.7

Comments

@slackpad
Copy link
Contributor

slackpad commented Feb 9, 2018 

$ make dist

...

--> solaris/amd64 error: exit status 2
Stderr: # github.com/hashicorp/consul/vendor/golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:13:3: //go:cgo_import_dynamic libc_pipe pipe "libc.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:14:3: //go:cgo_import_dynamic libc_getsockname getsockname "libsocket.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:15:3: //go:cgo_import_dynamic libc_getcwd getcwd "libc.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:16:3: //go:cgo_import_dynamic libc_getgroups getgroups "libc.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:17:3: //go:cgo_import_dynamic libc_setgroups setgroups "libc.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:18:3: //go:cgo_import_dynamic libc_wait4 wait4 "libc.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:19:3: //go:cgo_import_dynamic libc_gethostname gethostname "libc.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:20:3: //go:cgo_import_dynamic libc_utimes utimes "libc.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:21:3: //go:cgo_import_dynamic libc_utimensat utimensat "libc.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:22:3: //go:cgo_import_dynamic libc_fcntl fcntl "libc.so" only allowed in cgo-generated code
vendor/golang.org/x/sys/unix/zsyscall_solaris_amd64.go:22:3: too many errors

GNUmakefile:31: recipe for target 'bin' failed
make: *** [bin] Error 1
make: *** [dist] Error 2
@slackpad slackpad added the type/bug Feature does not function as expected label Feb 9, 2018
@slackpad slackpad added this to the Next milestone Feb 9, 2018
slackpad added a commit that referenced this issue Feb 9, 2018
@slackpad
Bumps Go version back down to 1.9.3.
0960112 
See #3879.
@slackpad
Copy link
Contributor Author

slackpad commented Feb 9, 2018

We reverted back to Go 1.9.3 for tomorrow's release of Consul 1.0.6, but we should investigate this and upgrade Go again as soon as possible.

@hairyhenderson
Copy link

@slackpad FYI - this was fixed in Go 1.10 - https://golang.org/cl/94018

@estesp estesp mentioned this issue Feb 19, 2018
Merged
@pearkes pearkes modified the milestones: Next, 1.0.7 Mar 19, 2018
This was referenced Mar 27, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Feature does not function as expected
Projects
None yet
Milestone
1.0.7
Development

Successfully merging a pull request may close this issue.

Bumps go version to 1.10
3 participants
@slackpad @pearkes @hairyhenderson