Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can I disable agent api? #4557

Closed
myokoo opened this issue Aug 22, 2018 · 2 comments
Closed

Can I disable agent api? #4557

myokoo opened this issue Aug 22, 2018 · 2 comments
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/bug Feature does not function as expected
Milestone
1.3.0

Comments

@myokoo
Copy link

myokoo commented Aug 22, 2018

Hi there.

at v1.0.1.
By writing the following setting to default.json. Consul agent can disabled agent api.

"ports": {
    "http": -1
}

but v1.2.1.
Consul agent can't disable agent api.

$ /usr/local/bin/consul agent -config-dir=/etc/consul.d
WARNING: LAN keyring exists but -encrypt given, using keyring
==> Starting Consul agent...
==> Error starting agent: No suitable client address can be found

It seems that 3b6eef8 is affected.

Do I have to run the API?
if agent api can disable. please tel me.

Thanks!
@mkeeler mkeeler added type/bug Feature does not function as expected theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies labels Aug 22, 2018
@mkeeler
Copy link
Member

mkeeler commented Aug 22, 2018

@myokoo thanks for the report. This is a regression and will get fixed soon. You will be able to disable the http api but not if enabling connect.

@mkeeler mkeeler added this to the 1.2.3 milestone Aug 22, 2018
@myokoo
Copy link
Author

myokoo commented Aug 24, 2018

Thank you for your teachings.
I am looking forward to updating the version.

@pearkes pearkes added theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies and removed theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies labels Sep 10, 2018
@pearkes pearkes modified the milestones: 1.2.3, 1.3.0 Sep 11, 2018
@hanshasselberg hanshasselberg mentioned this issue Sep 11, 2018
Merged
hanshasselberg added a commit that referenced this issue Sep 11, 2018
@hanshasselberg
Allow disabling the HTTP API unless connect is enabled.
894e0b5 
If Connect is enabled, the HTTP API needs to be enabled and there is no
point in not having it. If Connect is disabled however, it should be
still possible to disable the HTTP API by configuring port `-1` for it.
Fixes #4557.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/bug Feature does not function as expected
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@pearkes @mkeeler @myokoo