Correct release changelog update script ("Unreleased")

[sixtus]

Edit from @pearkes:

We discovered in 1.4.0 and 1.4.1 that our automatic update of the release date as part of our release process isn't functioning as intended. We should fix this for our next release and verify the correct diff after tagging and prior to publishing.

[pearkes]

@sixtus I'm guessing you're referencing the changelog on the 1.4.0 tag, like this: https://github.com/hashicorp/consul/blob/v1.4.0/CHANGELOG.md.

On master it does have a date. I believe this was a bug / oversight in the release process for 1.4.0 and was noted at the time. I don't think we want to update the tag given the binaries are distributed with that sha embedded, which may cause different confusion.

Sorry about that and let me know if that makes sense.

[sixtus]

sorry for being ze german ;) makes sense - didn't think of the sha.

…

On Wed, Dec 12, 2018 at 10:05 PM Jack Pearkes ***@***.***> wrote: @sixtus <https://github.com/sixtus> I'm guessing you're referencing the changelog on the 1.4.0 tag, like this: https://github.com/hashicorp/consul/blob/v1.4.0/CHANGELOG.md. On master it does have a date. I believe this was a bug / oversight in the release process for 1.4.0 and was noted at the time. I don't think we want to update the tag given the binaries are distributed with that sha embedded, which may cause different confusion. Sorry about that and let me know if that makes sense. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5088 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFm0fs3efrKzzFjaWM1PupeCG3NNz6sks5u4W-RgaJpZM4ZQaGs> .

-- *Hagen Rother* Lead Architect | LiquidM ------------------------------ LiquidM Technology GmbH Rosenthaler Str. 36 | 10178 Berlin | Germany Phone: +49 176 15 00 38 77 Internet: www.liquidm.com | LinkedIn <https://www.linkedin.com/in/sixtus42/> ------------------------------ Managing Directors | André Bräuer, Philipp Simon, Thomas Hille Jurisdiction | Local Court Berlin-Charlottenburg HRB 152426 B

[sixtus]

you could branch and point the web site there. with a note that the released sha is the tag, not the branch. On Wed, Dec 12, 2018 at 11:31 PM Hagen Rother <hagen.rother@ligatus.com> wrote:

…

sorry for being ze german ;) makes sense - didn't think of the sha. On Wed, Dec 12, 2018 at 10:05 PM Jack Pearkes ***@***.***> wrote: > @sixtus <https://github.com/sixtus> I'm guessing you're referencing the > changelog on the 1.4.0 tag, like this: > https://github.com/hashicorp/consul/blob/v1.4.0/CHANGELOG.md. > > On master it does have a date. I believe this was a bug / oversight in > the release process for 1.4.0 and was noted at the time. I don't think we > want to update the tag given the binaries are distributed with that sha > embedded, which may cause different confusion. > > Sorry about that and let me know if that makes sense. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#5088 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAFm0fs3efrKzzFjaWM1PupeCG3NNz6sks5u4W-RgaJpZM4ZQaGs> > . > -- *Hagen Rother* Lead Architect | LiquidM ------------------------------ LiquidM Technology GmbH Rosenthaler Str. 36 | 10178 Berlin | Germany Phone: +49 176 15 00 38 77 Internet: www.liquidm.com | LinkedIn <https://www.linkedin.com/in/sixtus42/> ------------------------------ Managing Directors | André Bräuer, Philipp Simon, Thomas Hille Jurisdiction | Local Court Berlin-Charlottenburg HRB 152426 B

-- *Hagen Rother* Lead Architect | LiquidM ------------------------------ LiquidM Technology GmbH Rosenthaler Str. 36 | 10178 Berlin | Germany Phone: +49 176 15 00 38 77 Internet: www.liquidm.com | LinkedIn <https://www.linkedin.com/in/sixtus42/> ------------------------------ Managing Directors | André Bräuer, Philipp Simon, Thomas Hille Jurisdiction | Local Court Berlin-Charlottenburg HRB 152426 B

[pearkes]

Unfortunately we saw this again in 1.4.1. We'll be sure to fix this before 1.4.2 which is imminent due to #5270.

[pearkes]

We root caused this and this issue was not present in 1.4.2, released today.