Add default rpc address configuration option as CONSUL_RPC_ADDR env vari... #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Maybe we can add a small test for the RPC address if the env var is set. Otherwise this looks merge-ready. |
|
Only a couple of hours after my initial request. Awesome! 👍 A test would definitely be a good idea, given the current Travis failure: |
lalyos
force-pushed
the
add-rpc-addr-env-var
branch
from
a718085 to
94b93e0
Compare
…ariable Similar as in serf: hashicorp/serf#210
lalyos
force-pushed
the
add-rpc-addr-env-var
branch
from
94b93e0 to
89f271a
Compare
|
@ryanuber tests are added. |
|
Its funny to see that 4 lines of added code, influences 9 docs file changes and get tested by 60 lines of code ;) |
|
@lalyos great tests! Thanks for filling those in. Merging on in. |
ryanuber
added a commit
that referenced
this pull request
Dec 17, 2014
Add default rpc address configuration option as CONSUL_RPC_ADDR env vari...
mikedougherty
added a commit
to mikedougherty/consulate
that referenced
this pull request
Jun 18, 2015
To mimic behavior on consul CLI as in hashicorp/consul#542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...able
Similar as in serf: hashicorp/serf#210