-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: 209: introduce SERF_RPC_ADDR to do the same as -rpc-addr #210
Conversation
Maybe the command-line args should take precedence over the environment. Might be confusing to see |
Agree with @ryanuber, otherwise LGTM |
I was testing my code with this docker container: https://index.docker.io/u/crosbymichael/golang/ and worked fine, so i suspect maybe test are failing only with 'tip'
@ryanuber you're right, command-line args should take precendence. Something is strange with travis: I did the change, and was surprised by failing travis, so I
maybe the tests has some raceconditions? |
@lalyos Serf does have a bit of trouble with operations that involve timing while running the tests under travis CI. This has gotten a bit better over the last few months but can still be a little unpredictable. Your changes look good. Thanks! |
Fixes: 209: introduce SERF_RPC_ADDR to do the same as -rpc-addr
…ariable Similar as in serf: hashicorp/serf#210
No description provided.