-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of mapstructure in HTTP API #6147
Comments
I'm going to try to paste some of the context I gain on this issue as it comes to me, in case I drop off or someone else has ideas they can chime in. Wrote a more strenuous benchmark for
(gist of the benchmark is here just in case: https://gist.github.com/adams-sarah/44cb61871a1057da8fde05b059c0478a) |
We should cache mapstructure conversion results in the API (see below) or we could do the conversion before any field processing happens and just use those results everywhere. The decodeBody function is used by more than just the TXN API but it is most noticeable there given the types of requests typically made.
Quoting @mkeeler:
The text was updated successfully, but these errors were encountered: