Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS 1.3 in Go 1.13.x #6784

Closed
zeroflaw opened this issue Nov 13, 2019 · 3 comments · Fixed by #7325
Closed

Support TLS 1.3 in Go 1.13.x #6784

zeroflaw opened this issue Nov 13, 2019 · 3 comments · Fixed by #7325
Labels
type/enhancement Proposed improvement or new feature

Comments

@zeroflaw
Copy link

Feature Description

TLS 1.3 is available on an opt-out basis in Go 1.13. When Consul is updated to use the 1.13.x version of Go will the application be updated to support TLS 1.3?

https://golang.org/pkg/crypto/tls/

Use Case(s)

Builtin HTTPS Health checks fail if the minimum TLS version for a service is 1.3, it would be nice not to have to use an external python script in these circumstances

@banks banks added the type/enhancement Proposed improvement or new feature label Nov 13, 2019
@banks
Copy link
Member

banks commented Nov 13, 2019

Thanks for creating the issue @zeroflaw. We'd love to support TLS 1.3 once we upgrade and I'm not aware of any reason we'd opt out of that at this point. We'll check of course there are no risks or compatibility issues present if we do.

The blocker for now though is that Go 1.13 broke some of our Go module support and tooling so that we can't actually build Consul with it just yet. It shouldn't be anything major but is the reason we've not already upgraded the Go version.

@benjarrell
Copy link

@banks Is there an issue to track Go 1.13 compatibility?

@banks banks mentioned this issue Dec 4, 2019
@banks
Copy link
Member

banks commented Dec 4, 2019

There is now 😄 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants