support tls 1.3 #7325
support tls 1.3 #7325
Conversation
tlsutil/config.go
Outdated
| } | ||
|
|
||
| // TLSVersions has all the keys from the map above, make sure to keep both in sync | ||
| var TLSVersions = "tls10, tls11, tls12, tls13" |
There was a problem hiding this comment.
Couldn't we instead use an init func and programmatically generate this?
There was a problem hiding this comment.
Good catch! I went with a normal function instead. But the idea is the same.
tlsutil/config.go
Outdated
| } | ||
|
|
||
| // TLSVersions has all the keys from the map above, make sure to keep both in sync | ||
| var TLSVersions = "tls10, tls11, tls12, tls13" |
There was a problem hiding this comment.
I didn't want to have a function iterating over the keys again and again. And then I had a var with []string, but given we only ever join, I figured it could be a string as well in the first place.
There was a problem hiding this comment.
And I think it is better now because both vars are colocated and it is easier to spot the dependency than before.
There was a problem hiding this comment.
var TLSVersions string
func init() {
var versions []string
for version, _ := range TLSLookup {
versions = append(versions, version)
}
TLSVersions = strings.Join(versions, ", ")
}
There was a problem hiding this comment.
That should do a one time generation of the string. But like I said, it doesn't really matter. I doubt there will be a tls 1.4 any time soon. Its sort of like the copyright thing. You might change it once a year so is it worth keeping the code around rather than just updating it very rarely?
Fixes #6784