-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias check - referenced check not found behavior #7374
Comments
@oto313 I looked a bit, it is a bit more complicated:
It means that:
@rboyer Does it make sense (since you write the comment https://github.com/hashicorp/consul/blame/master/agent/checks/alias.go#L236 ) ? |
…sider it failing In current implementation of Consul, check alias cannot determine if a service exists or not. Because a service without any check is semantically considered as passing, so when no healthchecks are found for an agent, the check was considered as passing. But this make little sense as the current implementation does not make any difference between: * a non-existing service (passing) * a service without any check (passing as well) In order to make it work, we have to ensure that when a check did not find any healthcheck, the service does indeed exists. If it does not, lets consider the check as failing.
Hello @danielehc, I think this issue is not in status awaiting response since @oto313 has answered in my PR, saying it would probably fix the issue. Could a maintainer have a look at #7374? This is a problem we also have on our side |
Please search the existing issues for relevant feature requests, and use the reaction feature (https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to add upvotes to pre-existing requests.
Feature Description
Consul supports alias check which mirrors the state of a reference check. But in case the reference check does not exist the alias check is passing and the output message is "No checks found.". There could be an option for specifying behavior in such a situation. You could specify if it passes or fails.
There is already TODO in code: alias.go
Use Case(s)
In case you register services and checks (eg. one check and one alias check which points to the first check) and then deregister the referenced check which is used in alias check, the alias check is passing, even if the referenced check does not exist.
The text was updated successfully, but these errors were encountered: