Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle deprecated envoy fields with version sniffing #8205

Closed
rboyer opened this issue Jun 29, 2020 · 4 comments · Fixed by #8222
Closed

Handle deprecated envoy fields with version sniffing #8205

rboyer opened this issue Jun 29, 2020 · 4 comments · Fixed by #8222
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/envoy/xds Related to Envoy support

Comments

@rboyer
Copy link
Member

rboyer commented Jun 29, 2020

Several L7 configuration settings appear to have been deprecated with envoy 1.12, notably regex -> safe_regex and some of the other string matcher fields.

First significant deprecation section

Handle sending different results to older/newer envoy versions for all of these.
@rboyer rboyer added theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/envoy/xds Related to Envoy support labels Jun 29, 2020
@rboyer
Copy link
Member Author

rboyer commented Jun 29, 2020

Also we probably need a "kitchen sink" feature integration test to keep track of any xds fields we are using.

@rboyer
Copy link
Member Author

rboyer commented Jun 29, 2020

There may also be a way to turn the deprecated features back on temporarily as a stopgap.

@rboyer
Copy link
Member Author

rboyer commented Jun 29, 2020

For envoy 1.11 and 1.12 we can use DiscoveryRequest.Node.build_version https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/base.proto#envoy-api-msg-core-node

After that we can use the newer user_agent_* fields on the same struct.

@rboyer
Copy link
Member Author

rboyer commented Jun 29, 2020

Per the existing support matrix, we'll have to fix Consul 1.7 and 1.8 series to restore operation of those L7 features

This was referenced Jul 8, 2020
Merged
Merged
Merged
rboyer added a commit that referenced this issue Jul 9, 2020
@rboyer
[backport: 1.7.x] xds: version sniff envoy and switch regular express…
1b7a8ba 
…ions from 'regex' to 'safe_regex' on newer envoy versions (#8266)

cherry-pick of #8222 onto origin/release/1.7.x

Fixes: #8205
rboyer added a commit that referenced this issue Jul 9, 2020
@rboyer
[backport: 1.8.x] xds: version sniff envoy and switch regular express…
2142a69 
…ions from 'regex' to 'safe_regex' on newer envoy versions (#8265)

cherry-pick of #8222 onto origin/release/1.8.x

Fixes: #8205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/envoy/xds Related to Envoy support
Projects
None yet
Milestone
No milestone
1 participant
@rboyer