-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird error at startup with Consul 1.9.1: error gathering metrics: 13 error(s) occurred #9471
Closed
Comments
pierresouchay
added a commit
to pierresouchay/go-metrics
that referenced
this issue
Dec 29, 2020
When metrics are pre-registered with Help and without labels, when issuing metrics with labels, the help was filled with the key_name. But prometheus client enforces help to be consistent accross several elements, so, it can break at Runtime if a metric has been declared without its labels and later issued this metric with labels. In order to fix this, we store the help declared at startup for each key, so, when declaring a metric with some labels, we try to re-used pre-declared help for the metric. It should fix the issue that appeared with Consul 1.9.x and fix hashicorp/consul#9471
pierresouchay
added a commit
to pierresouchay/go-metrics
that referenced
this issue
Dec 29, 2020
When metrics are pre-registered with Help and without labels, when issuing metrics with labels, the help was filled with the key_name. But prometheus client enforces help to be consistent accross several elements, so, it can break at Runtime if a metric has been declared without its labels and later issued this metric with labels. In order to fix this, we store the help declared at startup for each key, so, when declaring a metric with some labels, we try to re-used pre-declared help for the metric. It should fix the issue that appeared with Consul 1.9.x and fix hashicorp/consul#9471
pierresouchay
added a commit
to pierresouchay/consul
that referenced
this issue
Jan 6, 2021
go-metrics is updated to 0.3.6 to properly handle help in prometheus metrics This fixes hashicorp#9303 and hashicorp#9471
pierresouchay
added a commit
to criteo-forks/consul
that referenced
this issue
Jan 7, 2021
go-metrics is updated to 0.3.6 to properly handle help in prometheus metrics This fixes hashicorp#9303 and hashicorp#9471
criteoconsul
pushed a commit
to criteo-forks/consul
that referenced
this issue
Feb 4, 2021
go-metrics is updated to 0.3.6 to properly handle help in prometheus metrics This fixes hashicorp#9303 and hashicorp#9471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview of the Issue
At startup, a weird message is issued when upgrading from 1.8.6 to 1.9.1:
This also happens in dev mode on master:
Reproduction Steps
Steps to reproduce this issue, eg:
telemetry{prometheus_retention_time = "192h"}
The text was updated successfully, but these errors were encountered: