api: ensure v1/health/ingress/:service endpoint works properly when streaming is enabled #9967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…treaming is enabled
rboyer
added a commit
that referenced
this pull request
Apr 5, 2021
…y when streaming is enabled Backport of #9967 to 1.9.x
dnephin
suggested changes
Apr 5, 2021
There was a problem hiding this comment.
Thank you for making this change! I think this roughly works, but moving it into the rpcclient/health.Client will ensure it is fixed in the right place for all callers.
I think when we chatted about it I suggested making the change in this spot, but now I realize that because we're having to switch the underlying cache, that isn't the case.
dnephin
approved these changes
Apr 5, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/345498. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The streaming cache type for service health has no way to handle
v1/health/ingress/:servicequeries as there is no equivalent topic that would return the appropriate data.This PR ensures that attempts to use this endpoint will use the old cache-type for now so that they return appropriate data when streaming is enabled.
Manual backport to 1.9.x #9968