Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.9.x] api: ensure v1/health/ingress/:service endpoint works properly when streaming is enabled #9968

Merged
merged 3 commits into from
Apr 5, 2021
Merged

[1.9.x] api: ensure v1/health/ingress/:service endpoint works properly when streaming is enabled #9968

merged 3 commits into from
Apr 5, 2021

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Apr 5, 2021

Backport of #9967 to 1.9.x

@rboyer
[1.9.x] api: ensure v1/health/ingress/:service endpoint works properl…
1833e66 
…y when streaming is enabled

Backport of #9967 to 1.9.x
@rboyer rboyer requested review from dnephin and a team April 5, 2021 15:48
@rboyer rboyer self-assigned this Apr 5, 2021
@vercel
Copy link

vercel bot commented Apr 5, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

consul-ui-staging – ./ui

🔍 Inspect: https://vercel.com/hashicorp/consul-ui-staging/BDhWtHSYwZCcixCc7BCUHw2Cu8f8
✅ Preview: Canceled

[Deployment for cc84d7e canceled]

@github-actions github-actions bot added the theme/health-checks Health Check functionality label Apr 5, 2021
@rboyer rboyer mentioned this pull request Apr 5, 2021
Merged
@vercel vercel bot temporarily deployed to Preview – consul April 5, 2021 18:04 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 5, 2021 18:04 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 5, 2021 18:06 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 5, 2021 18:06 Inactive
dnephin
dnephin approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for making this change!

@rboyer rboyer merged commit 8df30a4 into release/1.9.x Apr 5, 2021
@rboyer rboyer deleted the 1.9.x-fix-ingress-health-api branch April 5, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees

@rboyer rboyer

Labels
theme/health-checks Health Check functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rboyer @dnephin