ui: Fix nspace spacing issue #10157
Merged
ui: Fix nspace spacing issue #10157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxcode
approved these changes
May 6, 2021
johncowen
force-pushed
the
ui/bugfix/nspace-spacing
branch
from
4d4b183 to
4366c53
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/366376. |
|
🍒✅ Cherry pick of commit 90d1a30 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
May 10, 2021
This fixes the spacing bug in nspaces only by only showing Description if the namespace has one, and removing the extra 2 pixel margin of dds for when dts aren't rendered/don't exist.
|
🍒✅ Cherry pick of commit 90d1a30 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
May 10, 2021
This fixes the spacing bug in nspaces only by only showing Description if the namespace has one, and removing the extra 2 pixel margin of dds for when dts aren't rendered/don't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRed as a potential alternative approach to #9930.
, therefore in draft for the moment.This fixes the spacing bug in nspaces only by only showing
Descriptionif the namespace has one, and removing the extra 2 pixel margin ofdds for whendts aren't rendered/don't exist.If this is approved, there is still the outstanding design question of what to do for the various mixtures of lists containing icons/no-icons/mixture of icons/no-icons. But once we've decided what we want to do there, we can PR whatever the decision is separately.
Before:
After: