-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give descriptive error if auth method not found #10163
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:improvement | ||
acl: Give more descriptive error if auth method not found. | ||
``` |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -143,7 +143,7 @@ func TestLoginCommand(t *testing.T) { | |
|
||
code := cmd.Run(args) | ||
require.Equal(t, code, 1, "err: %s", ui.ErrorWriter.String()) | ||
require.Contains(t, ui.ErrorWriter.String(), "403 (ACL not found)") | ||
require.Contains(t, ui.ErrorWriter.String(), "500 (auth method \"test\" not found)") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we want a 500 response code for this. Either a 404 or 403 seems appropriate. There's some related context in #8520 (comment) (and the associated issue). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Totally agreed, didn't know how to do that but your suggestion works like a charm! |
||
}) | ||
|
||
testSessionID := testauth.StartSession() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, forgot to submit this comment:
I think we'll need something like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I swapped it around so it reads
ACL not found: auth method <blah> not found