Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: [BUGFIX] De-duplicate Tag rendering #10186

Merged
merged 5 commits into from
May 7, 2021
Merged

ui: [BUGFIX] De-duplicate Tag rendering #10186

merged 5 commits into from
May 7, 2021

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented May 5, 2021 •
edited
Loading

Fixes #10135

Notes:

  1. First commit includes failing acceptance tests
  2. Moved TagList component to a glimmer template only component and de-duped the tags (also added the ability to just specify @tags)
  3. Added docs

Tests are failing at the min 👀

@johncowen johncowen added theme/ui Anything related to the UI backport/1.9 labels May 5, 2021
@johncowen johncowen requested a review from kaxcode May 5, 2021 16:06
@johncowen johncowen added the type/bug Feature does not function as expected label May 5, 2021
@vercel vercel bot temporarily deployed to Preview – consul May 5, 2021 16:39 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 5, 2021 16:51 Inactive
kaxcode
kaxcode approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 LGTM

@johncowen johncowen force-pushed the ui/bugfix/tag-list branch from b017c05 to c5c26ba Compare May 7, 2021 10:58
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 7, 2021 10:58 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 7, 2021 10:58 Inactive
@johncowen johncowen merged commit 5400c81 into master May 7, 2021
@johncowen johncowen deleted the ui/bugfix/tag-list branch May 7, 2021 11:07
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/365508.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 5400c81 onto release/1.10.x succeeded!

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 5400c81 onto release/1.9.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request May 7, 2021
@johncowen @hc-github-team-consul-core
ui: [BUGFIX] De-duplicate Tag rendering (#10186)
16eb326 
* Add some tests for duplicated and non-duplicated tags

* Ensure tags get de-duped and add docs

* Update docs to include info on the recursive-ness
hc-github-team-consul-core pushed a commit that referenced this pull request May 7, 2021
@johncowen @hc-github-team-consul-core
ui: [BUGFIX] De-duplicate Tag rendering (#10186)
14fbeca 
* Add some tests for duplicated and non-duplicated tags

* Ensure tags get de-duped and add docs

* Update docs to include info on the recursive-ness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxcode kaxcode kaxcode approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI type/bug Feature does not function as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant service tags in the Consul UI
3 participants
@johncowen @hc-github-team-consul-core @kaxcode