Ensure passthrough clusters can be created #10301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously their creation was gated on the existence of the global mesh config. The associated listener filter chain was being created correctly.
freddygv
commented
May 26, 2021
| @@ -640,6 +640,14 @@ func TestClustersFromSnapshot(t *testing.T) { | |||
| { | |||
| name: "transparent-proxy", | |||
| create: proxycfg.TestConfigSnapshot, | |||
| setup: func(snap *proxycfg.ConfigSnapshot) { | |||
| snap.Proxy.Mode = structs.ProxyModeTransparent | |||
| snap.ConnectProxy.MeshConfigSet = true | |||
There was a problem hiding this comment.
The cluster should be created even if the config is nil.
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/375709. |
|
🍒✅ Cherry pick of commit 3532806 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously their creation was gated on the existence of the global mesh
config. The associated listener filter chain was being created
correctly.