-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure passthrough clusters can be created #10301
Conversation
Previously their creation was gated on the existence of the global mesh config. The associated listener filter chain was being created correctly.
@@ -640,6 +640,14 @@ func TestClustersFromSnapshot(t *testing.T) { | |||
{ | |||
name: "transparent-proxy", | |||
create: proxycfg.TestConfigSnapshot, | |||
setup: func(snap *proxycfg.ConfigSnapshot) { | |||
snap.Proxy.Mode = structs.ProxyModeTransparent | |||
snap.ConnectProxy.MeshConfigSet = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cluster should be created even if the config is nil.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/375709. |
🍒✅ Cherry pick of commit 3532806 onto |
Previously their creation was gated on the existence of the global mesh
config. The associated listener filter chain was being created
correctly.