Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update documentation with information about v1.10 licensing changes. #10336

Merged
merged 5 commits into from
Jun 3, 2021

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Jun 2, 2021

This PR is a culmination of the various changes to our documentation to account for the v1.10 licensing changes to consul enterprise. The PR contains 5 commits that can be viewed independently if desired. When viewing the telemetry docs I would recommend turning off whitespace diffs because I did fixup the giant metrics table to align all the column delimiters and it makes the diff look much more extensive than it otherwise would be.

@mkeeler mkeeler added type/docs Documentation needs to be created/updated/clarified backport/1.10 labels Jun 2, 2021
@mkeeler mkeeler added this to the 1.10.0 milestone Jun 2, 2021
@mkeeler mkeeler requested a review from a team June 2, 2021 18:47
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 2, 2021 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 2, 2021 19:12 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 2, 2021 19:17 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 2, 2021 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 2, 2021 19:23 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 2, 2021 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 3, 2021 13:40 Inactive
@mkeeler mkeeler added the pr/no-changelog PR does not need a corresponding .changelog entry label Jun 3, 2021
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one typo

Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, really comprehensive. I added a couple minor suggestions, but they're not blockers.

website/content/api-docs/operator/license.mdx Outdated Show resolved Hide resolved
website/content/commands/license.mdx Outdated Show resolved Hide resolved
website/content/commands/license.mdx Show resolved Hide resolved
website/content/docs/agent/telemetry.mdx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 3, 2021 14:48 Inactive
@mkeeler mkeeler merged commit 7f47603 into master Jun 3, 2021
@mkeeler mkeeler deleted the docs/licensing-updates branch June 3, 2021 14:50
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/379907.

@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit 7f47603 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jun 3, 2021
[Docs] Update documentation with information about v1.10 licensing changes.
Copy link
Contributor

@preetapan preetapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestions

@@ -12,7 +12,10 @@ Command: `consul license`

<EnterpriseAlert />

The `license` command provides datacenter-level management of the Consul Enterprise license. This was added in Consul 1.1.0.
The `license` command provides datacenter-level view of the Consul Enterprise license. This was added
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor grammar correction - should be "provides a data-center level view"

@@ -1636,6 +1636,8 @@ bind_addr = "{{ GetPrivateInterfaces | include \"network\" \"10.0.0.0/8\" | attr

- `leave_on_terminate` If enabled, when the agent receives a TERM signal, it will send a `Leave` message to the rest of the cluster and gracefully leave. The default behavior for this feature varies based on whether or not the agent is running as a client or a server (prior to Consul 0.7 the default value was unconditionally set to `false`). On agents in client-mode, this defaults to `true` and for agents in server-mode, this defaults to `false`.

- `license_path` <EnterpriseAlert inline /> This specifies the path to a file that contains the Consul Enterprise license. See the [licensing documentation](/docs/enterprise#licensing) for more information about Consul Enterprise license management.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a sentence that either this or the env vars are required to start Consul enterprise agents after 1.10.

Copy link
Member Author

@mkeeler mkeeler Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that for client agents in some circumstances neither this nor the env is required. That is why I preferred a link out to the other licensing documentation which goes over all those details rather than duplicating them here.

So maybe I should add something like.

Alternatively, the license may also be specified by the `CONSUL_LICENSE` or `CONSUL_LICENSE_PATH` environment variables.

Its a little less strong than saying one of the 3 is required but still gives the extra information. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants