Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 1.10 enterprise upgrade docs. #10446
Update 1.10 enterprise upgrade docs. #10446
Changes from 18 commits
b335d3d
b64cf5c
45c47df
3234948
970d601
dec29cc
68b8395
b9c4aec
b87e9db
31539d1
1201b40
137f64b
ade48cd
4b2fadf
335e071
a35d96e
fefdf5b
c493845
d63c3b1
55b890c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this link will be broken until we release 1.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the tabs approach which limits the apparent complexity. Perhaps we should make double sure this is easy to follow with a sentence above like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have a separate tab for Kubernetes? The upgrade path for Kubernetes will read slightly differently and I can either add it here as a suggestion or branch off of this PR branch and document it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, it would probably be good to have k8s instructions here too. but is another tab next to ACLs Enabled/ACLs Disabled the right place?
Would we need an ACLs enabled with k8s tab and one for disabled as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wouldnt need a separate tab for ACLs enabled vs disabled for Kubernetes as the helm chart manages that complexity under the hood for the user. They only need to provide us with the license file and we ensure we mount it to the right components depending on their existing configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact users will already have a license file in a secret so they only need to bump the Consul image and then run
helm upgrade
. Basically we should copy this text: https://www.consul.io/docs/enterprise/license/faq#kubernetes somewhere in here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lkysow We created a tab for Kubernetes and have described just that. We could add the faq steps there as well. The only additional thing we added were steps to ensure people who had consul servers external to kubernetes had steps that they could follow as well. https://consul-m514xwknh-hashicorp.vercel.app/docs/upgrading/instructions/upgrade-to-1-10-x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect