check expiry date of the root/intermediate before using it to sign a leaf #10500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhiaayachi
commented
Jun 30, 2021
dhiaayachi
commented
Jun 30, 2021
dhiaayachi
commented
Jun 30, 2021
kyhavlov
reviewed
Jun 30, 2021
dhiaayachi
commented
Jun 30, 2021
dnephin
reviewed
Jul 8, 2021
This further decouples the CAManager from Server. It reduces the interface between them and removes the need for the SetLogger method on providers.
To reduce the scope of Server, and keep all the CA logic together
Most of these methods are used exclusively for the AutoConfig RPC endpoint. This PR uses a pattern that we've used in other places as an incremental step to reducing the scope of Server.
dhiaayachi
force-pushed
the
dnephin/ca-provider-explore-2
branch
from
ecb30aa
to
6356302
Compare
To reduce the scope of Server, and keep all the CA logic together
Co-authored-by: Kyle Havlovitz <kylehav@gmail.com>
dnephin
force-pushed
the
dnephin/ca-provider-explore-2
branch
from
4fb20c8
to
5ed56fc
Compare
This reverts commit 6356302.
freddygv
approved these changes
Jul 13, 2021
Co-authored-by: Freddy <freddygv@users.noreply.github.com>
dhiaayachi
changed the title
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/408262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9573
This need to be merged after #10479