Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync enterprise files with oss #10705

Merged
merged 1 commit into from
Jul 27, 2021
Merged

sync enterprise files with oss #10705

merged 1 commit into from
Jul 27, 2021

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Jul 27, 2021 •
edited
Loading

Updates to test files and comments from enterprise PR feedback

@kisunji kisunji added backport/1.8 pr/no-changelog PR does not need a corresponding .changelog entry labels Jul 27, 2021
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 27, 2021 19:15 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 27, 2021 19:15 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 27, 2021 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 27, 2021 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 27, 2021 20:43 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 27, 2021 20:43 Inactive
dnephin
dnephin approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kisunji kisunji merged commit 9c3af1a into main Jul 27, 2021
@kisunji kisunji deleted the kisunji/pr-feedback-ent branch July 27, 2021 21:10
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/417226.

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 9c3af1a onto release/1.10.x failed! Build Log

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 9c3af1a onto release/1.9.x failed! Build Log

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 9c3af1a onto release/1.8.x failed! Build Log

kisunji pushed a commit that referenced this pull request Jul 28, 2021
sync enterprise files with oss (#10705)
50ac64f 
(cherry picked from commit 9c3af1a)
kisunji pushed a commit that referenced this pull request Jul 28, 2021
sync enterprise files with oss (#10705)
c3af197 
(cherry picked from commit 9c3af1a)
kisunji pushed a commit that referenced this pull request Jul 28, 2021
sync enterprise files with oss (#10705)
dbaab42 
(cherry picked from commit 9c3af1a)
kisunji pushed a commit that referenced this pull request Jul 28, 2021
sync enterprise files with oss (#10705) (#10711)
9a57ae9 
(cherry picked from commit 9c3af1a)
kisunji pushed a commit that referenced this pull request Jul 28, 2021
sync enterprise files with oss (#10705) (#10712)
4b7d223 
(cherry picked from commit 9c3af1a)
kisunji pushed a commit that referenced this pull request Jul 28, 2021
sync enterprise files with oss (#10705) (#10713)
3ac0ba3 
(cherry picked from commit 9c3af1a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kisunji @hc-github-team-consul-core @dnephin