-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync enterprise files with oss #10705
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisunji
added
backport/1.8
pr/no-changelog
PR does not need a corresponding .changelog entry
labels
Jul 27, 2021
kisunji
force-pushed
the
kisunji/pr-feedback-ent
branch
from
July 27, 2021 19:15
95e0bde
to
34566fd
Compare
kisunji
force-pushed
the
kisunji/pr-feedback-ent
branch
from
July 27, 2021 20:18
34566fd
to
abc2cb4
Compare
kisunji
force-pushed
the
kisunji/pr-feedback-ent
branch
from
July 27, 2021 20:43
abc2cb4
to
8cba538
Compare
dnephin
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/417226. |
kisunji
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 9c3af1a)
kisunji
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 9c3af1a)
kisunji
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 9c3af1a)
kisunji
pushed a commit
that referenced
this pull request
Jul 28, 2021
kisunji
pushed a commit
that referenced
this pull request
Jul 28, 2021
kisunji
pushed a commit
that referenced
this pull request
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to test files and comments from enterprise PR feedback