Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl: rename tokens to Root and AgentRoot #10741

Closed
wants to merge 1 commit into from
Closed

acl: rename tokens to Root and AgentRoot #10741

wants to merge 1 commit into from

Conversation

mikemorris
Copy link
Contributor

@mikemorris mikemorris commented Jul 30, 2021 •
edited
Loading

Rough first pass at renaming the ACL Master and AgentMaster tokens to Root and AgentRoot. All the current changes are just simple renaming and website or docs updates, but I have a few outstanding questions before this is ready to be pulled out of a draft state:

  • Legacy ACLs - it will likely be easier to wait for these to be removed entirely rather than actually renaming and figuring out any compatibility issues
  • Is there a need to support any transitory state, such as upgrading from a 1.10 to 1.11 Consul release, and how might we best handle that?
  • Are there concerns with changing protobuf wire format, e.g. should the existing fields be preserved/deprecated and new fields added instead of renaming?
  • consul/api module - figure out how we might want to handle this change in a backwards compatible way

@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/ui Anything related to the UI type/docs Documentation needs to be created/updated/clarified labels Jul 30, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul July 30, 2021 20:47 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 30, 2021 20:47 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 30, 2021 22:23 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 30, 2021 22:31 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 30, 2021 22:31 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 30, 2021 23:41 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 30, 2021 23:41 Inactive
@mikemorris
acl: rename tokens to Root and AgentRoot
8058dd5 
docs: update proxycfg link in contributing to main branch

website: update refs to ACL root and agent root tokens

acl: regen proto for Root and AgentRoot token config

changelog: add entry for renaming tokens to Root and AgentRoot
@mikemorris mikemorris force-pushed the agent/acl-root-token-rename branch from 451fe44 to 8058dd5 Compare August 3, 2021 15:29
@kisunji
Copy link
Contributor

kisunji commented Aug 3, 2021

Are there concerns with changing protobuf wire format, e.g. should the existing fields be preserved/deprecated and new fields added instead of renaming?

Renames of existing fields are safe to do on pb definitions!

@johncowen johncowen removed the theme/ui Anything related to the UI label Aug 20, 2021
@jkirschner-hashicorp jkirschner-hashicorp mentioned this pull request Sep 20, 2021
Closed
@rboyer rboyer added this to the 1.11.0 milestone Nov 10, 2021
@mikemorris
Copy link
Contributor Author

Outdated, work completed in the following series of PRs:

@mikemorris mikemorris closed this Dec 14, 2021
@mikemorris mikemorris deleted the agent/acl-root-token-rename branch December 14, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mikemorris @hashicorp-ci @kisunji @rboyer @johncowen