Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Always show main navigation Key/Value link #10916

Merged
merged 3 commits into from
Sep 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/10916.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
```release-note:bug
ui: Ignore reported permissions for KV area meaning the KV is always enabled
for both read/write access if the HTTP API allows.
```
11 changes: 11 additions & 0 deletions ui/packages/consul-ui/app/abilities/kv.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,15 @@ export default class KVAbility extends BaseAbility {
}
return resources;
}
get canRead() {
return true;
}

get canList() {
return true;
}

get canWrite() {
return true;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,21 @@ Feature: dc / acls / tokens / index: ACL Token List
Then the url should be /dc-1/acls/tokens
And the title should be "Tokens - Consul"
Then I see 3 token models
Scenario: Viewing tokens with no write access
Given 1 datacenter model with the value "dc-1"
And 3 token models
And permissions from yaml
---
acl:
write: false
---
When I visit the tokens page for yaml
---
dc: dc-1
---
Then the url should be /dc-1/acls/tokens
And I don't see create

Scenario: Searching the tokens
Given 1 datacenter model with the value "dc-1"
And 4 token models from yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Feature: dc / kvs / index
Then the url should be /dc-1/kv
And the title should be "Key/Value - Consul"
Then I see 3 kv models
@ignore
Scenario: Viewing kvs with no write access
Given 1 datacenter model with the value "dc-1"
And 3 kv models
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,18 @@ Feature: navigation-links: Main Navigation link visibility
Allow: true
- Resource: key
Access: read
Allow: false
Allow: true
- Resource: intention
Access: read
Allow: true
- Resource: acl
Access: read
Allow: true
Allow: false
---
When I visit the services page for yaml
---
dc: dc-1
---
Then I see services on the navigation
Then I don't see kvs on the navigation
Then I don't see roles on the navigation