ui: Partitions Application Layer #11017

johncowen · 2021-09-13T14:51:37Z

This PR adds ready-only support for Admin Partitions to the UI and is a continuation of:

Please see those ^ PRs for background.

As discussed offline I decided to split this up by application concerns rather than 'business' concerns. i.e. it is split by:

Support multiple 'optional' URL segments in the UI/app across the board (ui: Support Route optional parameters/segments #10212)
Add support for partitions for the HTTP API we use in the UI/app across the board (ui: Adds Partitions to the HTTP layer #10447)
Add Admin Partitions to the application/frontend layer of the UI/app across the board (this PR)

Why split it this way?

Admin partition support for the UI (and Consul as a whole) is something that touches absolutely everything in a very similar way. The change is basically adding partition=, Partition, :partition, ${partition} everywhere in the UI.

As an engineer, I see it as much easier to see where a single change needs to be made, and then almost copy and paste that single change to Services, Nodes, KV, Tokens, Policies, Roles, Namespaces, Auth Methods and Binding Rules. At which point everything is broken as you've only made a single change, and therefore none of the tests pass. You can then systematically keep going with this approach: See where the next change needs to be made, and then almost copy and paste that change to Services, Nodes, KV, Tokens, Policies, Roles, Namespaces, Auth Methods and Binding Rules. Again, everything will be broken until you've got through every change that needs to be made, again and again and again, by which point everything should be mostly working and the tests mostly passing, leaving only minimal test changes to update (again a single change and copy paste to every single test). This approach means that you are far less likely to miss an important bit that you didn't change because you forgot about that bit by the time you get to the next PR if it was split by business concerns.

If we had have split this up by business concerns instead (so UI 'section by section') none of our tests would have been passing for a couple of weeks, confusing other unrelated work that is going on in tandem, potentially blocking others.

I figured we could still split this somewhat in the 3 PRs mentioned above, and whilst this makes this final PR a little large, a large part of the change here is actually deletions, documentation and test tweaks (~150 of the files changed here are these files).

This means that whilst the files changed is ~330, its more like ~180. Despite this, I appreciate its still a quite few files to look at. Additionally here, the main takeaway is the vast majority of changes here are just adding the word partition everywhere.

There are a handful of additional changes which I made whilst I was here, which have been spoken about in previous PRs and offline in RFCs and suchlike, and also things like upgrading the odd syntax change now we use ES6 syntax for everything (this will help us upgrade to the next Ember LTS, our current Ember is no longer receiving any security updates). I've also added a fair amount of self-review/inline comments to the majority of these things to try to help review/reviewers. I've also PRed this whilst leaving the majority of the testing until last so folks could get a head start on review.

Overall I did the best I could so that as a reviewer, it is hopefully as easy as possible to review.

~~Kind of still in draft~~, but good to start getting 👀 here, so definitely open for review as it stands. ~~There will be some changes ontop. I'll add a description shortly~~ (best viewing commit by commit ~~for now~~).

Lastly apologies for the lateness of the PR description, I was concentrating on getting the work done and staying green in CI in order to aim for a potential release yesterday, and I kinda figured folks would know what this was for and why and I was doing it.

Whilst this is approved and been merged, there is still time to answer questions and make any necessary amends. Please use this PR for any review/comments and we can try to address anything in a separate, iterative PR before any potential release.

johncowen

Added a bunch of inline notes before adding a PR description

johncowen · 2021-09-13T15:21:22Z

ui/packages/consul-ui/app/instance-initializers/container.js

@@ -13,7 +13,7 @@ export default {
    let repositories = container
      .get('container-debug-adapter:main')
      .catalogEntriesByType('service')
-      .filter(item => item.startsWith('repository/'));
+      .filter(item => item.startsWith('repository/') || item === 'ui-config');


ui-config should be a repository. Added a little workaround here, rather than moving things around, but that should be changed as soon as possible to make it work like the rest of the application (including a completely async API)

why is ui-config added a repository here?

johncowen · 2021-09-13T15:25:18Z

ui/packages/consul-ui/app/adapters/partition.js

+
+      ${{ index }}
+    `;
+    await respond((headers, body) => delete headers['x-consul-index']);


Its just easier to do all this (re-shaping the response and the request) in the same place.

The actual request is tightly coupled to the response, so the adapter/serializer split has always felt to me like decoupling for the sake of decoupling. Doing it here for all our adapters would also mean we can get rid of a bunch of code that is a little bit out of the ordinary (our fake HTTP headers to pass this value around), plus all the tests that go with it. Ideally we'd have an even nicer format to use for re-shaping but for now this is fine.

johncowen · 2021-09-13T15:26:43Z

ui/packages/consul-ui/app/components/consul/acl/disabled/index.hbs

+    </EmptyState>
+  </BlockSlot>
+</AppView>
+


We now have an 'ACLs disabled' component instead of building it into AppView. I've left the old one in AppView for the moment. It will probably be removed as part of the removal of legacy ACLs.

johncowen · 2021-09-13T15:29:11Z

ui/packages/consul-ui/app/components/data-loader/index.hbs

          <Notification @sticky={{true}}>
            <p data-notification role="alert" class="warning notification-update">
              <strong>Warning!</strong>
              An error was returned whilst loading this data, refresh to try again.
            </p>
          </Notification>
+        {{/if}}


If its a 401 (unauthorized) then don't show the disconnection message, just immediately try to reauth. Failure will then just show our default 403 error page.

johncowen · 2021-09-13T15:30:12Z

ui/packages/consul-ui/app/components/data-source/index.js

+      typeof this.data.rollbackAttributes === 'function'
+    ) {
+      this.data.rollbackAttributes();
+    }


If the data is a single item and it hasn't been saved at all, then roll it back when the DataSource is removed from the page.

johncowen · 2021-09-13T15:52:35Z

ui/packages/consul-ui/app/services/ui-config.js

+      }
+      return prev;
+    }, {});
+  }


All of this stuff is now so much easier to think about (the stuff we removed was in the application error hook)

johncowen · 2021-09-13T15:53:51Z

ui/packages/consul-ui/app/templates/application.hbs

  {{document-attrs class="has-nspaces"}}
 {{/if}}
+{{#if (can "use partitions")}}
+  {{document-attrs class="has-partitions"}}
+{{/if}}


We are converting almost all our in-template env usage to use can (almost all meaning all the *_ENABLED related envs). So I did this while I was here.

johncowen · 2021-09-13T15:54:55Z

ui/packages/consul-ui/app/templates/dc/acls/auth-methods/index.hbs

+
+    <BlockSlot @name="error">
+    {{#if (eq loader.error.status '401')}}
+      <Consul::Acl::Disabled />


Here's our new ACLs Disabled component, if we get a 401 here it means ACLs are disabled.

johncowen · 2021-09-13T15:56:31Z

ui/packages/consul-ui/app/templates/dc/acls/policies/edit.hbs

      {{else}}
-            View Policy
+            <route.Title @title="View Policy" />


Note we are no longer doubling up/repeating all the logic for titles, we just reuse the output of <route.Title> which also does our HTML <title> and our route announcing.

johncowen · 2021-09-13T15:58:53Z

ui/packages/consul-ui/app/templates/dc/acls/tokens/index.hbs

@@ -86,7 +105,7 @@ as |route|>
          <collection.Collection>
            <Consul::Token::List
              @items={{collection.items}}
-              @token={{token}}
+              @token={{route.model.user.token}}


We added a route.model.user in our application.hbs that is live/reactive based on the users localStorage value. This is then drilled down to all our route templates via the <Rout/let>, which pretty much means we don't ever have to be concerned with loading this in anywhere else.

jnwright · 2021-09-14T15:28:29Z

@johncowen dropdown selector title should be singular (Admin Partition)

johncowen · 2021-09-14T15:40:27Z

@jnwright oh good spot! 😂 Removed an s, thankyou!

johncowen · 2021-09-15T14:53:53Z

Just a quick note here that this is all now passing green. There are a few FIXMEs I would like to get to, but again they shouldn't block an approval/merge. Gonna think about whether I want to do those in another PR 🤔

johncowen

Added a bunch more inline comments.

johncowen · 2021-09-15T16:44:13Z

ui/packages/consul-ui/app/routing/route.js

  /**
   * Set the routeName for the controller so that it is available in the template
   * for the route/controller.. This is mainly used to give a route name to the
   * Outlet component
   */
  setupController(controller, model) {
    setProperties(controller, {
+      ...model,


We used to have a setupController in every single route, we moved it to the parent class and just used inheritance instead. We generally don't need to do this anymore, but I've left it in here for now. This setupController is likely to be removed soon. I saw a while ago whilst attempting an Ember upgrade that you are no longer allowed as much access to the Controller as we used to, so if we want to upgrade and not have even more deprecation messages this will probably need to go. I'll hopefully be able to try and bump an Ember upgrade pretty soon as I'm not totally sure the version we are currently on is still under LTS. This means that if we need to do something about it, its now in one place instead of about 30 places.

johncowen · 2021-09-15T16:46:58Z

ui/packages/consul-ui/app/services/client/http.js

                [CONSUL_DATACENTER]: params.data.dc,
                [CONSUL_NAMESPACE]: params.data.ns || token.Namespace || 'default',
+                // FIXME: Is the default partition '' or 'default'?
+                [CONSUL_PARTITION]: params.data.partition || token.Partition || 'default',


I 'think' this is definitely still going to be default for the default partition so I think this FIXME is fine. I'll try double check and remove in another PR.

johncowen · 2021-09-15T16:49:22Z

ui/packages/consul-ui/app/services/repository.js

  findAllByDatacenter(params, configuration = {}) {
+    return this.findAll(...arguments);
+  }


Things in repositories no longer need to be named anything specific as we use our dataSource annotations to refer to them, the name ...AllByDatacenter had outgrown its meaning (as we no dow things by datacenters, nspace and partition) so really we mean findAll and just pass any amount of things as params. Final note here, whilst method names don't really matter for application code, they are still important for DX/engineers reading the code, so they should be as meaningful as possible.

When we finally remove the findAllByDatacenter methods, it will mean changing a tonne of tests also, so I left it in for now as that wasn't necessary here.

johncowen · 2021-09-15T16:52:33Z

ui/packages/consul-ui/app/services/repository/coordinate.js

+      results = tomography(params.id, coordinates);
+    }
+    results.meta = coordinates.meta;
+    return results;


Almost all of these repository methods should now include async as they should all be asynchronous methods. We only did a few here were we absolutely needed as it means a tonne of test changes (a handful of which you'll see below), but we wanted to avoid refactoring a bunch of stuff in this PR. We can do this in a follow up PR.

johncowen · 2021-09-15T16:55:04Z

ui/packages/consul-ui/app/services/repository/intention.js

+      });
+    } else {
+      item = super.findBySlug(...arguments);
+    }


Just incase I didn't mention elsewhere, all findBySlugs will in future include defaulting to a new model if no 'slug'/'id' has been specified. This is much more flexible and means its easy to tweak the creation of models per model type. This means will mean we can remove some similar functionality from our <DataSink/> component meaning that component will do less.

Again something I decided wasn't necessary so I left it for a future PR.

johncowen · 2021-09-15T17:03:27Z

ui/packages/consul-ui/tests/integration/serializers/auth-method-test.js

            };
            const body = payload;
            return cb(headers, body);
          },
          {
            dc: dc,
            ns: nspace,
+            partition: partition,


Changes to serializer tests just add partition, so again the changes here are done the same for every data model, again and again and again.

johncowen · 2021-09-15T17:04:24Z

ui/packages/consul-ui/tests/integration/services/repository/auth-method-test.js

-                uid: `["${item.Namespace || undefinedNspace}","${dc}","${item.Name}"]`,
+                Partition: item.Partition || undefinedPartition,
+                uid: `["${item.Partition || undefinedPartition}","${item.Namespace ||
+                  undefinedNspace}","${dc}","${item.Name}"]`,


Similar to serializer tests, repo test changes just add partition again and again and again for every single repository.

johncowen · 2021-09-15T17:05:37Z

ui/packages/consul-ui/tests/steps/interactions/form.js

-      return page.fillIn(name, value);
+      const $el = document.querySelector(`[name="${name}"]`);
+      fillIn($el, value);
+      return page;


As mentioned in the commit, for some reason ember-cli-page-object 'fillables' just stopped working, no idea why, I switched back to ember test helpers instead which I believe is more up to date than ember-cli-page-object things.

johncowen · 2021-09-15T17:06:34Z

ui/packages/consul-ui/tests/unit/mixins/creating-route-test.js

-    let subject = CreatingRouteObject.create();
-    assert.ok(subject);
-  });
-});


With this change I could finally get rid of a load of our mixins, again this will help us get onto the next ember LTS.

johncowen · 2021-09-15T17:07:08Z

ui/packages/consul-ui/tests/unit/routes/dc/intentions/edit-test.js

-    let route = this.owner.lookup('route:dc/intentions/edit');
-    assert.ok(route);
-  });
-});


Most of our Route tests are removed as we no longer have Routes to test.

kaxcode

Rebasing needed before merge

johncowen · 2021-09-15T18:44:22Z

Thanks, I think this is good to go again

kaxcode

This PR is approved to be merged. Due to time constraints and the size of this PR, a review post-merge is required.

cc @mikemorris

hc-github-team-consul-core · 2021-09-15T18:50:49Z

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/445517.

johncowen · 2021-09-16T10:47:09Z

Thanks @kaxcode , as I've just mentioned in the PR description here, please feel free to continue reviewing this here. Although it's merged here already, we can use this PR to get any of your questions and/or suggestions answered and make any further amends in the separate PR. In the meantime I'll be working on some of the FIXMEs for a separate PR. As discussed offline, I learnt a great approach from other folks here by using FIXMEs for things that should ideally by fixed in the PR itself, whilst TODOs are longer lived, so I'll be trying to figure those FIXMEs out until I hear back from you.

kaxcode · 2021-09-20T19:00:39Z

@johncowen - Post-merge review
Here are some questions that cover several files:

Can you consciously explain what the most impactful changes were for adding Admin Partitions to the FE layer of the app?
Why is x-consul-index header getting deleted in some adapters?
Why are we creating a new ACLs disabled component instead of using the old one?
How do the route.title and route.announcer changes relate to admin partitions?
How do the changes to the router.js and all routes files relate to admin partitions?
Why are the mixins getting deleted in this PR?
Why are repo for nspace disabled and enabled deleted in this PR?

Note: I skipped reviewing the 91 test files

kaxcode · 2021-09-20T18:36:57Z

ui/packages/consul-ui/app/adapters/nspace.js

@@ -3,9 +3,9 @@ import { SLUG_KEY } from 'consul-ui/models/nspace';

 // namespaces aren't categorized by datacenter, therefore no dc
 export default class NspaceAdapter extends Adapter {
-  requestForQuery(request, { partition, index, uri }) {
+  requestForQuery(request, { dc, partition, index, uri }) {


why is dc getting added to this adapter?

Nspaces can now be different depending on which dc/partition you are in, so we need to qualify this call with an extra dc param.

kaxcode · 2021-09-20T18:37:37Z

ui/packages/consul-ui/app/components/consul/kv/form/index.hbs

@@ -19,11 +20,11 @@
 {{#if api.isCreate}}
        <label class="type-text{{if api.data.error.Key ' has-error'}}">
            <span>Key or folder</span>
-            <input autofocus="autofocus" type="text" value={{left-trim api.data.Key parent.Key}} name="additional" oninput={{action api.change}} placeholder="Key or folder" />
+            <input autofocus="autofocus" type="text" value={{left-trim api.data.Key parent}} name="additional" oninput={{action api.change}} placeholder="Key or folder" />


why is parent.Key no longer needed?

I think I changed this so that parent is the same as parent.Key. We only ever used parent.Key so figured it was easier to just use parent for a name.

kaxcode · 2021-09-20T18:38:06Z

ui/packages/consul-ui/app/components/data-form/index.js

@@ -46,7 +46,7 @@ export default Component.extend(Slotted, {
      }
      // mark as creating
      // and autofill the new record if required
-      if (get(changeset, 'isNew')) {
+      if (get(data, 'isNew')) {


why change from changset to data?

It was something related to changeset/ember-data. From what I remember I found that for some reason isNew wouldn't punch through the proxy to the underlying ember-data object, then I realised we have access here to the actual ember-data object a few lines up, so I just referenced that instead.

kaxcode · 2021-09-20T18:38:59Z

ui/packages/consul-ui/app/components/hashicorp-consul/index.hbs

@@ -28,7 +26,7 @@
            <BlockSlot @name="menu">
 {{#let components.MenuItem components.MenuSeparator as |MenuItem MenuSeparator|}}
              <DataSource
-                @src="/*/*/datacenters"
+                @src="/*/*/*/datacenters"


why in this scenario is partitions left out?

Datacenters aren't split by partition, they are the top level 'thing' so no need to provide a partition here.

kaxcode · 2021-09-20T18:39:44Z

ui/packages/consul-ui/app/instance-initializers/container.js

@@ -13,7 +13,7 @@ export default {
    let repositories = container
      .get('container-debug-adapter:main')
      .catalogEntriesByType('service')
-      .filter(item => item.startsWith('repository/'));
+      .filter(item => item.startsWith('repository/') || item === 'ui-config');


why is ui-config added a repository here?

kaxcode · 2021-09-20T18:51:45Z

ui/packages/consul-ui/app/serializers/nspace.js

-          if (get(item, 'ACLs.PolicyDefaults')) {
-            item.ACLs.PolicyDefaults = item.ACLs.PolicyDefaults.map(function(item) {
-              item.template = '';
+  respondForQuery(respond, query, data, modelClass) {


Can you share more details on the refactoring for this file?

I added item.Namespace = item.Name and also item.Datacenter = query.dc, for keying purposes. Also, now nspaces need to be keyed by DC, I moved it back to use the parent method so that it goes through the apps uid extra fingerprinting like the rest of the app (previously it didn't need the extra keying as namespaces used to be a top level bucket). The rest is just indenting.

kaxcode · 2021-09-20T18:53:06Z

ui/packages/consul-ui/app/services/repository/dc.js

-    return Promise.reject({ errors: [e] });
-  }
-
-  async getActive(name, items) {


Can you explain the factoring/deletions for this file?

We don't uses these extra repo methods anymore. There's probably a bit more I can get rid of from this file actually 🤔 . The little refactor is just to add partition and use the parent class method instead of store.

kaxcode · 2021-09-20T18:53:47Z

ui/packages/consul-ui/app/services/repository/nspace.js

 import RepositoryService from 'consul-ui/services/repository';
 import { PRIMARY_KEY, SLUG_KEY } from 'consul-ui/models/nspace';
 import dataSource from 'consul-ui/decorators/data-source';

+const findActiveNspace = function(nspaces, nspace) {


Can you explain all the new additions in this file?

Its to make it all consistent (dc's, nspaces and partitions are all very similar now). TBH I think a lot of this can now be deleted 🤔

kaxcode · 2021-09-20T18:54:38Z

ui/packages/consul-ui/app/templates/application.hbs

-    @name="application"
-    @model={{hash
-      app=consul
+{{! If ACLs are enabled try get a token }}


Can you explain the new additions in this file?

I left quite a few comments in the file here to explain to folks what was happening. Its pretty much the same as what there used to be, just the code has been moved elsewhere. Is there anything specific here you want me to explain ontop of the comments?

johncowen · 2021-09-27T14:18:42Z

Hey! Thanks for the review and the questions!

I added a few inline answers and I'll try answer these other ones here:

Can you consciously explain what the most impactful changes were for adding Admin Partitions to the FE layer of the app?

I'd say probably deleting a lot of code was the most impactful code change here. Means everything is a lot easier now. Namespace and partitions are now pretty much the same thing, and accessing params and data for them works just the same as any other param/data in the app. There are no little "oh, this is slightly different cos its nspaces" or "oh, you access this from here instead of where you usually would as its partitions". Now its all nice and consistent (mostly)

Why is x-consul-index header getting deleted in some adapters?

This disables blocking queries for the 'section' so for example I think here specifically we use it to disable blocking queries for KV (which have never had blocking queries enabled)

Why are we creating a new ACLs disabled component instead of using the old one?
There wasn't an old one. The only code for this was tied up in the AppView, which didn't make complete sense as the ACLs disabled view is only used in the ACLs area. Made sense to make it a component and only use it in ACLs.

How do the route.title and route.announcer changes relate to admin partitions?
Previously the @title attribute meant we needed data available before the Route component was on the page:

<Route @title={{item.Something}} />

...with this change we don't have some data until after the Route is on the page so we moved it to use a contextual component instead, so this change was required:

<Route @title={{i can't access route here}} as |route|> <== I needed access to route
  <route.Title @title={{route.params}} /> <== now I have access to route and other things
</Route>

As I was doing this it felt like it was a good opportunity to make it more ergonomic and usable also, so I did that while I was there. I also took the opportunity to add some basic but useful documentation to explain this here https://github.com/hashicorp/consul/tree/581357c32a29de2640f2ec2f9b1274c4615db2f8/ui/packages/consul-ui/app/components/route#route hopefully that will also be useful moving forwards.

How do the changes to the router.js and all routes files relate to admin partitions?

We don't need the majority of routes files anymore, there was a fair amount of logic duplication in them. Now there isn't, it's all in one place. There are super minimal changes to router.js related to whether ACLs are enabled or not.

Why are the mixins getting deleted in this PR?

We don't need most if them anymore. I combined all the remaining ones into one file (which will soon be deleted so we can upgrade ember). There was a fair amount of legacy ACLs that was in the way a little here (we probably should have done that "Legacy ACL removal" work first). So I deleted quite a bit of stuff to avoid going through the extra effort it work for partitions, which would have been pointless.

Why are repo for nspace disabled and enabled deleted in this PR?

This was originally a way to make it less complex to write differences between both 'modes'. Nspaces have been around a while now and I realised that the differences are so minimal this extra split into two classes was almost pointless, so I removed them here, this meant I could follow the same thing for the new partitions repository (which also doesn't have an enabled/disabled split).

Lemme know if you have any more q's.

johncowen added the theme/ui Anything related to the UI label Sep 13, 2021

johncowen requested a review from kaxcode September 13, 2021 14:51

johncowen added this to the 1.11.0 milestone Sep 13, 2021

johncowen commented Sep 13, 2021

View reviewed changes

vercel bot deployed to Preview – consul-ui-staging September 14, 2021 14:56 View deployment

vercel bot temporarily deployed to Preview – consul September 14, 2021 14:56 Inactive

vercel bot temporarily deployed to Preview – consul September 14, 2021 15:39 Inactive

vercel bot deployed to Preview – consul-ui-staging September 14, 2021 15:39 View deployment

vercel bot deployed to Preview – consul-ui-staging September 15, 2021 12:13 View deployment

vercel bot temporarily deployed to Preview – consul September 15, 2021 12:13 Inactive

vercel bot deployed to Preview – consul-ui-staging September 15, 2021 12:18 View deployment

vercel bot temporarily deployed to Preview – consul September 15, 2021 12:18 Inactive

vercel bot temporarily deployed to Preview – consul September 15, 2021 12:27 Inactive

vercel bot deployed to Preview – consul-ui-staging September 15, 2021 12:27 View deployment

vercel bot temporarily deployed to Preview – consul September 15, 2021 12:59 Inactive

vercel bot deployed to Preview – consul-ui-staging September 15, 2021 12:59 View deployment

vercel bot deployed to Preview – consul-ui-staging September 15, 2021 13:28 View deployment

vercel bot temporarily deployed to Preview – consul September 15, 2021 13:28 Inactive

vercel bot deployed to Preview – consul-ui-staging September 15, 2021 13:42 View deployment

vercel bot temporarily deployed to Preview – consul September 15, 2021 13:42 Inactive

johncowen commented Sep 15, 2021

View reviewed changes

Base automatically changed from ui/feature/partitions-api to main September 15, 2021 17:09

kaxcode suggested changes Sep 15, 2021

View reviewed changes

John Cowen added 4 commits September 15, 2021 19:32

Add Partition to all our models

749f4d8

Add partitions into our serializers/fingerprinting

4381d70

Make some amends to a few adapters ready for partitions

a080270

Amend blueprints to avoid linting error

987156a

John Cowen added 8 commits September 15, 2021 19:32

Fixup adapter tests to follow async/function resolving interface

93a14fe

Fixup all the serializer integration tests

d8b8d3a

Fixup service/repo integration tests

6c52671

Lint

96538e6

Fixup deleting acceptance test

8f37799

Fixup some ent tests

d855446

Make sure nspaces passes the dc through for when thats important

acd219b

...aaaand acceptance nspaces with the extra dc param

88e3122

johncowen force-pushed the ui/feature/partitions-glue branch from 11a83ad to 88e3122 Compare September 15, 2021 18:36

vercel bot deployed to Preview – consul-ui-staging September 15, 2021 18:36 View deployment

vercel bot temporarily deployed to Preview – consul September 15, 2021 18:36 Inactive

johncowen added the pr/no-changelog PR does not need a corresponding .changelog entry label Sep 15, 2021

kaxcode approved these changes Sep 15, 2021

View reviewed changes

johncowen merged commit fc14a41 into main Sep 15, 2021

johncowen deleted the ui/feature/partitions-glue branch September 15, 2021 18:50

This was referenced Sep 16, 2021

ui: Address some Admin Partition FIXMEs #11057

Merged

ui: Gracefully recover from non-existent DC errors #11077

Merged

kaxcode reviewed Sep 20, 2021

View reviewed changes

This was referenced Sep 21, 2021

ui: Remove legacy ACLs #11096

Merged

ui: Remove routeName from tokens route, we do this app wide #10877

Closed

ui: Add partition support to intentions #11129

Merged

This was referenced Oct 6, 2021

ui: Fix up blocking reconciliation for multiple models #11237

Merged

ui: Ignore erroneous ember/jquery eslint warnings #11238

Merged

johncowen mentioned this pull request Oct 14, 2021

ui: Remove remaining partition FIXME comments #11312

Merged

johncowen mentioned this pull request Nov 26, 2021

ui: Refactor KV and Lock Sessions following partitions update #11666

Merged

ui: Partitions Application Layer #11017

ui: Partitions Application Layer #11017

Conversation

johncowen commented Sep 13, 2021 • edited Loading

Why split it this way?

johncowen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johncowen Sep 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnwright commented Sep 14, 2021

johncowen commented Sep 14, 2021 • edited Loading

johncowen commented Sep 15, 2021

johncowen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johncowen Sep 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johncowen Sep 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaxcode left a comment

Choose a reason for hiding this comment

johncowen commented Sep 15, 2021

kaxcode left a comment

Choose a reason for hiding this comment

hc-github-team-consul-core commented Sep 15, 2021

johncowen commented Sep 16, 2021

kaxcode commented Sep 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johncowen commented Sep 27, 2021

johncowen commented Sep 13, 2021 •

edited

Loading

johncowen Sep 13, 2021 •

edited

Loading

johncowen commented Sep 14, 2021 •

edited

Loading

johncowen Sep 15, 2021 •

edited

Loading

johncowen Sep 15, 2021 •

edited

Loading

kaxcode commented Sep 20, 2021 •

edited

Loading