Document SDS for ingress gateways #11164
Conversation
github-actions
bot
added
theme/envoy/xds
There was a problem hiding this comment.
Thanks for adding the docs content @banks . I left some suggestions and questions for you. I also tagged @trujillo-adam to review from a tech writing perspective.
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
banks
force-pushed
the
feature/ingress-tls-mixed
branch
2 times, most recently
from
985f93b
to
d65bb33
Compare
banks
force-pushed
the
docs/ingress-sds
branch
from
9733c6d
to
6216c1b
Compare
banks
changed the base branch from
feature/ingress-tls-mixed
to
docs/mesh-header-manip
banks
force-pushed
the
docs/mesh-header-manip
branch
from
afcfb47
to
fe92cf7
Compare
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
|
Thanks for all the reviews folks. This fell off my radar a bit - I had some other work locally that didn't get pushed up, but I'll get the feedback all incorporated this week so it's done and merged in time for GA. |
Co-authored-by: mrspanishviking <kcardenas@hashicorp.com>
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
banks
force-pushed
the
docs/ingress-sds
branch
from
1a3b40f
to
1d85afe
Compare
|
Thanks @trujillo-adam and @freddygv, I finally got around to completing my edits here. I think this addresses all the feedback so far and looks good to me. If you want to take another pass, feel free otherwise i'll merge this in a few days to make sure it makes it into 1.11 on time! |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/527813. |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/527833. |
|
🍒✅ Cherry pick of commit 131897b onto |
Document SDS for ingress gateways
This PR adds documentation for features added in #10903 and #11163.
These are "low-level" features designed to be used by systems integration builders rather than typical-end users but are included to provide a complete example so this functionality can be used. I don't anticipate a Learn guide for this feature as it's more of an integration interface so included a somewhat guide-like complete example of getting the whole feature to work.
If anyone can think of a better place to put the more detailed guide than the ingress gateway overview page I'd be open to suggestions.
Preview: https://consul-o89qrzjyl-hashicorp.vercel.app/docs/connect/config-entries/ingress-gateway#sds