-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document SDS for ingress gateways #11164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the docs content @banks . I left some suggestions and questions for you. I also tagged @trujillo-adam to review from a tech writing perspective.
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
985f93b
to
d65bb33
Compare
9733c6d
to
6216c1b
Compare
afcfb47
to
fe92cf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few questions and made some formatting suggestions that you can take or leave.
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a couple minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions.
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
Thanks for all the reviews folks. This fell off my radar a bit - I had some other work locally that didn't get pushed up, but I'll get the feedback all incorporated this week so it's done and merged in time for GA. |
Co-authored-by: mrspanishviking <kcardenas@hashicorp.com>
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
1a3b40f
to
1d85afe
Compare
Thanks @trujillo-adam and @freddygv, I finally got around to completing my edits here. I think this addresses all the feedback so far and looks good to me. If you want to take another pass, feel free otherwise i'll merge this in a few days to make sure it makes it into 1.11 on time! |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/527813. |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/527833. |
🍒✅ Cherry pick of commit 131897b onto |
Document SDS for ingress gateways
This PR adds documentation for features added in #10903 and #11163.
These are "low-level" features designed to be used by systems integration builders rather than typical-end users but are included to provide a complete example so this functionality can be used. I don't anticipate a Learn guide for this feature as it's more of an integration interface so included a somewhat guide-like complete example of getting the whole feature to work.
If anyone can think of a better place to put the more detailed guide than the ingress gateway overview page I'd be open to suggestions.
Preview: https://consul-o89qrzjyl-hashicorp.vercel.app/docs/connect/config-entries/ingress-gateway#sds