Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: Add support for Envoy 1.20 #11277

Merged
merged 11 commits into from
Oct 28, 2021
Merged

connect: Add support for Envoy 1.20 #11277

merged 11 commits into from
Oct 28, 2021

Conversation

eculver
Copy link
Contributor

@eculver eculver commented Oct 12, 2021

Adds support in our integration test suite and configuration for testing against Envoy 1.20.0. I'll drop support for 1.16 in a subsequent PR similar to what was done in #11115 and #11118.

There were no significant changes needed to get the integration suite to pass.

@eculver eculver requested review from rboyer, freddygv and a team October 12, 2021 01:54
@github-actions github-actions bot added theme/cli Flags and documentation for the CLI interface theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases labels Oct 12, 2021
@eculver eculver requested a review from a team as a code owner October 12, 2021 01:58
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 12, 2021 01:58 Inactive
@vercel vercel bot temporarily deployed to Preview – consul October 12, 2021 01:58 Inactive
rboyer
rboyer approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 12, 2021 16:18 Inactive
@vercel vercel bot temporarily deployed to Preview – consul October 12, 2021 16:18 Inactive
@eculver eculver mentioned this pull request Oct 19, 2021
Merged
1 task
@vercel vercel bot temporarily deployed to Preview – consul October 28, 2021 00:41 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 28, 2021 00:41 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 28, 2021 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview – consul October 28, 2021 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview – consul October 28, 2021 01:17 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 28, 2021 01:17 Inactive
@eculver eculver merged commit bec08f4 into main Oct 28, 2021
@eculver eculver deleted the eculver/envoy-1.20.0 branch October 28, 2021 01:38
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/487793.

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit bec08f4 onto stable-website failed! Build Log

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit bec08f4 onto release/1.10.x failed! Build Log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer approved these changes

@freddygv freddygv Awaiting requested review from freddygv

Assignees
No one assigned
Labels
theme/cli Flags and documentation for the CLI interface theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eculver @hc-github-team-consul-core @rboyer