Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix leadership transfer on leave suggestions #11387

Merged
merged 2 commits into from
Oct 21, 2021
Merged

fix leadership transfer on leave suggestions #11387

merged 2 commits into from
Oct 21, 2021

Conversation

dhiaayachi
Copy link
Contributor

to finish #11376

@dhiaayachi dhiaayachi added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.9 labels Oct 21, 2021
dnephin
dnephin reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes!

I think I missed one thing in my earlier suggestion. I think we still need one else for when attemptLeadershipTransfer == true, to set isLeader = false before we continue on.

@vercel vercel bot temporarily deployed to Preview – consul October 21, 2021 17:16 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 21, 2021 17:16 Inactive
@dhiaayachi
Copy link
Contributor Author

Thanks for making these changes!

I think I missed one thing in my earlier suggestion. I think we still need one else for when attemptLeadershipTransfer == true, to set isLeader = false before we continue on.

yes, just added this

@dhiaayachi dhiaayachi mentioned this pull request Oct 21, 2021
Merged
@dhiaayachi dhiaayachi merged commit 58f5686 into main Oct 21, 2021
@dhiaayachi dhiaayachi deleted the fix-leader-transfer-onleave branch October 21, 2021 18:02
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/481289.

@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit 58f5686 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Oct 21, 2021
@dhiaayachi @hc-github-team-consul-core
fix leadership transfer on leave suggestions (#11387)
cb64d77 
* add suggestions

* set isLeader to false when leadership transfer succeed
@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit 58f5686 onto release/1.9.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Oct 21, 2021
@dhiaayachi @hc-github-team-consul-core
fix leadership transfer on leave suggestions (#11387)
004939d 
* add suggestions

* set isLeader to false when leadership transfer succeed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhiaayachi @hc-github-team-consul-core @dnephin