-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix leadership transfer on leave suggestions #11387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes!
I think I missed one thing in my earlier suggestion. I think we still need one else
for when attemptLeadershipTransfer == true
, to set isLeader = false
before we continue on.
yes, just added this |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/481289. |
🍒✅ Cherry pick of commit 58f5686 onto |
* add suggestions * set isLeader to false when leadership transfer succeed
🍒✅ Cherry pick of commit 58f5686 onto |
* add suggestions * set isLeader to false when leadership transfer succeed
to finish #11376