Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix autopilot_failure_tolerance, add autopilot metrics test case #11399

Merged
merged 1 commit into from
Oct 25, 2021
Merged

fix autopilot_failure_tolerance, add autopilot metrics test case #11399

merged 1 commit into from
Oct 25, 2021

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Oct 22, 2021 •
edited
Loading

Overview

The main goal of this PR is to fix the behavior of the autopilot_failure_tolerance metric. The metric should emit:

  • NaN on startup
  • NaN on follower servers
  • an actual value on leaders
  • no clients should emit this value

PR Checklist

  • tests
  • gofmt
  • go mod -- n/a

Issues Related

Signed-off-by: FFMMM FFMMM@users.noreply.github.com

@acpana acpana force-pushed the ffmmm/fix-autopilot-tolerance-metric branch from d8c7204 to 904fb8a Compare October 22, 2021 19:48
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 22, 2021 19:48 Inactive
@vercel vercel bot temporarily deployed to Preview – consul October 22, 2021 19:48 Inactive
@acpana acpana marked this pull request as ready for review October 22, 2021 19:59
@acpana acpana mentioned this pull request Oct 22, 2021
Closed
dnephin
dnephin approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor suggestion in the tests

agent/metrics_test.go Outdated Show resolved Hide resolved
@acpana acpana force-pushed the ffmmm/fix-autopilot-tolerance-metric branch from 904fb8a to 5b82ccc Compare October 25, 2021 17:02
@vercel vercel bot temporarily deployed to Preview – consul October 25, 2021 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 25, 2021 17:02 Inactive
@FFMMM
fix autopilot_failure_tolerance, add autopilot metrics test case
7c36431 
Signed-off-by: FFMMM <FFMMM@users.noreply.github.com>
@acpana acpana force-pushed the ffmmm/fix-autopilot-tolerance-metric branch from 5b82ccc to 7c36431 Compare October 25, 2021 17:30
@vercel vercel bot temporarily deployed to Preview – consul October 25, 2021 17:30 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 25, 2021 17:30 Inactive
@acpana acpana merged commit fea6f08 into main Oct 25, 2021
@acpana acpana deleted the ffmmm/fix-autopilot-tolerance-metric branch October 25, 2021 17:56
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/484061.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit fea6f08 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Oct 25, 2021
@FFMMM @hc-github-team-consul-core
fix autopilot_failure_tolerance, add autopilot metrics test case (#11399
85a173e 
)

Signed-off-by: FFMMM <FFMMM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acpana @hc-github-team-consul-core @dnephin @FFMMM