Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: code-editor-styling #11474

Merged
merged 21 commits into from
Nov 12, 2021
Merged

ui: code-editor-styling #11474

merged 21 commits into from
Nov 12, 2021

Commits on Nov 2, 2021

  1. WIP: code-editor-styling 

    shame level: HIGH

lots of TODOs and also a HACK to be handled.
This commit will have to be reworded as well

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    7dfbc6e View commit details
    Browse the repository at this point in the history

  2. changelog 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    ba53c6a View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. fix: toolbar title & link for policies 

    not sure if it's the best practice but I used a hash to achieve
conditional rendering of the help link by passing a prop to CodeEditor

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    f2cfacd View commit details
    Browse the repository at this point in the history

  2. fix: width fix + dropdown styling 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    5035cfd View commit details
    Browse the repository at this point in the history

  3. fix: toolbar styling variables 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    c9444da View commit details
    Browse the repository at this point in the history

  4. fix: ACL rules docs link on fieldsets-legacy 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    363e432 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. WIP: code-editor-styling 

    shame level: HIGH

lots of TODOs and also a HACK to be handled.
This commit will have to be reworded as well

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    c72b6fc View commit details
    Browse the repository at this point in the history

  2. changelog 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    a662d5f View commit details
    Browse the repository at this point in the history

  3. fix: toolbar title & link for policies 

    not sure if it's the best practice but I used a hash to achieve
conditional rendering of the help link by passing a prop to CodeEditor

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    76ac2a8 View commit details
    Browse the repository at this point in the history

  4. fix: width fix + dropdown styling 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    e97e76f View commit details
    Browse the repository at this point in the history

  5. fix: toolbar styling variables 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    614cc51 View commit details
    Browse the repository at this point in the history

  6. fix: ACL rules docs link on fieldsets-legacy 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    d241512 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'ui/bugfix/code-editor-styling' of github.com:deblasis/c… 

    …onsul into ui/bugfix/code-editor-styling
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    8bada55 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'hashicorp:main' into ui/bugfix/code-editor-styling

    @deblasis
    deblasis authored Nov 4, 2021
    Configuration menu
    Copy the full SHA
    5f3bee3 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'ui/bugfix/code-editor-styling' of github.com:deblasis/c… 

    …onsul into ui/bugfix/code-editor-styling
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    bb014ff View commit details
    Browse the repository at this point in the history

  10. refactoring: using named blocks 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    bca9ad0 View commit details
    Browse the repository at this point in the history

  11. fix: removed unnecessary property 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    3a3d0ef View commit details
    Browse the repository at this point in the history

  12. fix: themeable black/white in dropdown 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    b149aff View commit details
    Browse the repository at this point in the history

  13. fix: use variables for border 

    Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    24c43a2 View commit details
    Browse the repository at this point in the history

  14. ui: CodeEditor refactoring 

    - :label named block
- :tools named block
- :content named block
- code and CSS cleanup
- CodeEditor.mdx

Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
    @deblasis
    deblasis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    ed20fb7 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Update ui/packages/consul-ui/app/components/code-editor/README.mdx 

    Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
    @deblasis @johncowen
    deblasis and johncowen authored Nov 12, 2021
    Configuration menu
    Copy the full SHA
    f160233 View commit details
    Browse the repository at this point in the history