Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ca: set the correct SigningKeyID after config update with Vault provider #11672

Merged
merged 1 commit into from
Dec 2, 2021
Merged

ca: set the correct SigningKeyID after config update with Vault provider #11672

merged 1 commit into from
Dec 2, 2021

Commits on Dec 2, 2021

  1. ca: set the correct SigningKeyID after config update with Vault provider 

    The test added in this commit shows the problem. Previously the
SigningKeyID was set to the RootCert not the local leaf signing cert.

This same bug was fixed in two other places back in 2019, but this last one was
missed.

While fixing this bug I noticed I had the same few lines of code in 3
places, so I extracted a new function for them.

There would be 4 places, but currently the InitializeCA flow sets this
SigningKeyID in a different way, so I've left that alone for now.
    @dnephin
    dnephin committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    17a2d14 View commit details
    Browse the repository at this point in the history