-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect: Upgrade Envoy 1.20 to 1.20.1 #11895
Conversation
🤔 This PR has changes in the |
@@ -35,7 +35,7 @@ compatible Envoy versions. | |||
|
|||
| Consul Version | Compatible Envoy Versions | | |||
| ------------------- | ------------------------------------------------------ | | |||
| 1.11.x | 1.20.0, 1.19.1, 1.18.4, 1.17.4 | | |||
| 1.11.x | 1.20.1, 1.19.1, 1.18.4, 1.17.4 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we still claim compatibility with Envoy 1.20.0 for Consul 1.11.x or did we drop 1.20.0 support between 1.10.x and 1.11.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually only point to the latest Envoy release since older versions contain CVEs and have vulnerabilities
@@ -126,7 +126,7 @@ func TestDetermineSupportedProxyFeaturesFromString(t *testing.T) { | |||
"1.17.0", "1.17.1", "1.17.2", "1.17.3", "1.17.4", | |||
"1.18.0", "1.18.1", "1.18.2", "1.18.3", "1.18.4", | |||
"1.19.0", "1.19.1", | |||
"1.20.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be replacing or appending?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we should probably append?
Co-authored-by: David Yu <dyu@hashicorp.com>
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/556738. |
🍒✅ Cherry pick of commit e35dd08 onto |
Thanks for merging this @kisunji! |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/557054. |
🍒✅ Cherry pick of commit e35dd08 onto |
Envoy 1.20.1 was released on 11/30/21: https://www.envoyproxy.io/docs/envoy/v1.20.1/version_history/current. This upgrades our integration to use this latest release.