Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: Upgrade Envoy 1.20 to 1.20.1 #11895

Merged
merged 3 commits into from
Jan 18, 2022
Merged

connect: Upgrade Envoy 1.20 to 1.20.1 #11895

merged 3 commits into from
Jan 18, 2022

Conversation

eculver
Copy link
Contributor

@eculver eculver commented Dec 20, 2021

Envoy 1.20.1 was released on 11/30/21: https://www.envoyproxy.io/docs/envoy/v1.20.1/version_history/current. This upgrades our integration to use this latest release.

@eculver eculver requested review from rboyer, freddygv and a team December 20, 2021 18:10
@eculver eculver requested a review from a team as a code owner December 20, 2021 18:10
@github-actions github-actions bot added theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified labels Dec 20, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging December 20, 2021 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – consul December 20, 2021 18:24 Inactive
@@ -35,7 +35,7 @@ compatible Envoy versions.

| Consul Version | Compatible Envoy Versions |
| ------------------- | ------------------------------------------------------ |
| 1.11.x | 1.20.0, 1.19.1, 1.18.4, 1.17.4 |
| 1.11.x | 1.20.1, 1.19.1, 1.18.4, 1.17.4 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still claim compatibility with Envoy 1.20.0 for Consul 1.11.x or did we drop 1.20.0 support between 1.10.x and 1.11.x?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually only point to the latest Envoy release since older versions contain CVEs and have vulnerabilities

@@ -126,7 +126,7 @@ func TestDetermineSupportedProxyFeaturesFromString(t *testing.T) {
"1.17.0", "1.17.1", "1.17.2", "1.17.3", "1.17.4",
"1.18.0", "1.18.1", "1.18.2", "1.18.3", "1.18.4",
"1.19.0", "1.19.1",
"1.20.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be replacing or appending?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we should probably append?

agent/xds/envoy_versioning_test.go Outdated Show resolved Hide resolved
Co-authored-by: David Yu <dyu@hashicorp.com>
@vercel vercel bot temporarily deployed to Preview – consul January 18, 2022 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 18, 2022 18:57 Inactive
@kisunji kisunji merged commit e35dd08 into main Jan 18, 2022
@kisunji kisunji deleted the eculver/envoy-1.20.1 branch January 18, 2022 19:35
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/556738.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit e35dd08 onto release/1.11.x succeeded!

@eculver
Copy link
Contributor Author

eculver commented Jan 18, 2022

Thanks for merging this @kisunji!

@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/557054.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit e35dd08 onto stable-website succeeded!

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit e35dd08 onto release/1.11.x failed! Build Log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants