Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Fix dark borders on certain visualizations #11959

Merged
merged 2 commits into from
Jan 7, 2022
Merged

ui: Fix dark borders on certain visualizations #11959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46dcf09
ui: Fix dark borders on certain visualizations
Jan 6, 2022
bddcd05
Changelog
Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/11959.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fixes a visual issue with some border colors
```
10 changes: 8 additions & 2 deletions ui/packages/consul-ui/app/components/consul/discovery-chain/skin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@
}
%chain-group {
border-radius: var(--decor-radius-100);
border: 1px solid rgb(var(--tone-gray-200));
border: 1px solid;
/* TODO: If this color is combined with the above */
/* border property then the compressor removes the color */
border-color: rgb(var(--tone-gray-200));
background-color: rgb(var(--tone-gray-100));

pointer-events: none;
Expand Down Expand Up @@ -102,7 +105,10 @@
background-color: rgb(var(--tone-gray-000));

border-radius: var(--decor-radius-full);
border: 2px solid rgb(var(--tone-gray-400));
border: 2px solid;
/* TODO: If this color is combined with the above */
/* border property then the compressor removes the color */
border-color: rgb(var(--tone-gray-400));
}
%discovery-chain circle {
stroke-width: 2;
Expand Down
5 changes: 4 additions & 1 deletion ui/packages/consul-ui/app/components/topology-metrics/card/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
overflow: hidden;
background-color: rgb(var(--tone-gray-000));
border-radius: var(--decor-radius-100);
border: 1px solid rgb(var(--tone-gray-200));
border: 1px solid;
/* TODO: If this color is combined with the above */
/* border property then the compressor removes the color */
border-color: rgb(var(--tone-gray-200));
p {
padding: 12px 12px 0 12px;
font-size: var(--typo-size-500);
Expand Down
5 changes: 4 additions & 1 deletion ui/packages/consul-ui/app/components/topology-metrics/skin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@
#downstream-container,
#metrics-container,
#upstream-container {
border: 1px solid rgb(var(--tone-gray-200));
border-radius: var(--decor-radius-100);
border: 1px solid;
/* TODO: If this color is combined with the above */
/* border property then the compressor removes the color */
border-color: rgb(var(--tone-gray-200));
}
#downstream-container,
#upstream-container {
Expand Down